diff options
| author | Tor Lillqvist <tlillqvist@novell.com> | 2011-01-18 16:25:52 +0200 |
|---|---|---|
| committer | Tor Lillqvist <tlillqvist@novell.com> | 2011-01-18 16:36:34 +0200 |
| commit | e17ba9b2dd6f34c2af9fea5a1696ab454bcd6562 (patch) | |
| tree | 53dc3a86afebcc72370bce1c6a4b45b9c2453ec6 /vcl | |
| parent | 96bb26df5b009c969d0999cfbb61faf2c27ffbf8 (diff) | |
Avoid GetHelpText() call which can be quite heavy
GetHelpText() can cause a quite heavy sequence of file and directory
lookups. See fdo#33088. As its return value here was just passed on to
ShowHelpStatusText() which doesn't do anything at all, it was
completely unnecessary. The GetHelpText() calls here caused the
noticeable slowdown in highlighting menu items on Windows with lots of
localised help files for some bundled extensions.
(cherry picked from commit 6fc21aa74b4d2aba07d854d5d3c2f404905b40ef)
Signed-off-by: Caolan McNamara <caolanm@redhat.com>
Signed-off-by: Michael Meeks <michael.meeks@novell.com>
Signed-off-by: Thorsten Behrens <thb@documentfoundation.org>
Signed-off-by: fstrba@novell.com
Diffstat (limited to 'vcl')
| -rw-r--r-- | vcl/source/window/menu.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index e6722c3d90d3..41555312b249 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -1119,9 +1119,6 @@ void Menu::Highlight() if ( pStartMenu && ( pStartMenu != this ) ) pStartMenu->aHighlightHdl.Call( this ); } - - if ( !aDelData.isDeleted() && GetCurItemId() ) - GetpApp()->ShowHelpStatusText( GetHelpText( GetCurItemId() ) ); } void Menu::ImplSelect() |