summaryrefslogtreecommitdiff
path: root/vcl
diff options
context:
space:
mode:
authorJochen Nitschke <j.nitschke+logerrit@ok.de>2017-09-11 17:08:33 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-09-12 06:48:17 +0200
commit7e2a6709d9511f983f9981258c38ccc125bcd3fe (patch)
tree6a7b444d3e8b65c5d22e9bcf26ee4ae04d04b03c /vcl
parent75ca51725274b95417aa2c7f169145e3cd3b3b4f (diff)
cppcheck: identicalConditionAfterEarlyExit
Change-Id: I59d91390ee303eadc10315405cce44cfd7c37d56 Reviewed-on: https://gerrit.libreoffice.org/42179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl')
-rw-r--r--vcl/source/gdi/print3.cxx7
1 files changed, 1 insertions, 6 deletions
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index e70c4d02dd82..a825d0b23438 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -1266,16 +1266,11 @@ DrawModeFlags PrinterController::removeTransparencies( GDIMetaFile const & i_rIn
void PrinterController::printFilteredPage( int i_nPage )
{
if( mpImplData->meJobState != css::view::PrintableState_JOB_STARTED )
- return;
+ return; // rhbz#657394: check that we are still printing...
GDIMetaFile aPageFile;
PrinterController::PageSize aPageSize = getFilteredPageFile( i_nPage, aPageFile );
- if (mpImplData->meJobState != css::view::PrintableState_JOB_STARTED)
- { // rhbz#657394: check that we are still printing...
- return;
- }
-
if( mpImplData->mpProgress )
{
// do nothing if printing is canceled