diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-10-08 10:20:52 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-10-08 12:52:01 +0200 |
| commit | da1e9cba89128de05b8681469cdbc154f7624aad (patch) | |
| tree | 0a34528e81b07c39514157586fd44575e53f2e7a /vcl/unx/gtk3/gtkinst.cxx | |
| parent | a44c77d6548fac62f760ae152ddc09381d005129 (diff) | |
sort buttons using id instead of HelpId
when created from the builder a widget's HelpId is the patch to the
widget and always ends in the widget id so this is no change for that
case, but when created directly by vcl for e.g. a MessageDialog while
the id is set the helpid is empty, so this means that Yes/No
MessageDialogs have their buttons sorted the same as if the Yes/No
buttons were explicitly spelled out in a builder .ui
Change-Id: Iee1a7146d2b6da76804856b1c4df8849ddd91a0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123253
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/unx/gtk3/gtkinst.cxx')
| -rw-r--r-- | vcl/unx/gtk3/gtkinst.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index 3cd60a2777a6..ec87c2785741 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -5732,7 +5732,8 @@ namespace { bool sortButtons(const GtkWidget* pA, const GtkWidget* pB) { //order within groups according to platform rules - return getButtonPriority(::get_help_id(pA)) < getButtonPriority(::get_help_id(pB)); + return getButtonPriority(get_buildable_id(GTK_BUILDABLE(pA))) < + getButtonPriority(get_buildable_id(GTK_BUILDABLE(pB))); } void sort_native_button_order(GtkBox* pContainer) |