diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-05-25 09:35:57 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-05-25 12:32:54 +0100 |
commit | acad8441cc40b7b0f91681d6827f8364de05046e (patch) | |
tree | 2be1315764dc269557a60fb36a48d86b7ed23402 /vcl/source | |
parent | 12b6bca821a7b0137fcac243f8aa078ba1a152ad (diff) |
cppcheck: noExplicitConstructor
Change-Id: I62076450ab77472bfd09b3fb9824f54b6ea1e0f7
Diffstat (limited to 'vcl/source')
27 files changed, 41 insertions, 41 deletions
diff --git a/vcl/source/app/IconThemeInfo.cxx b/vcl/source/app/IconThemeInfo.cxx index 869eb85e40db..9531bf493ffe 100644 --- a/vcl/source/app/IconThemeInfo.cxx +++ b/vcl/source/app/IconThemeInfo.cxx @@ -132,7 +132,7 @@ namespace private: const OUString& m_rThemeId; public: - SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} + explicit SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} bool operator()(const vcl::IconThemeInfo &rInfo) { return m_rThemeId == rInfo.GetThemeId(); diff --git a/vcl/source/app/IconThemeScanner.cxx b/vcl/source/app/IconThemeScanner.cxx index 45346cb3be45..29f1a9142f4e 100644 --- a/vcl/source/app/IconThemeScanner.cxx +++ b/vcl/source/app/IconThemeScanner.cxx @@ -181,7 +181,7 @@ namespace private: const OUString& m_rThemeId; public: - SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} + explicit SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} bool operator()(const vcl::IconThemeInfo &rInfo) { return m_rThemeId == rInfo.GetThemeId(); diff --git a/vcl/source/app/IconThemeSelector.cxx b/vcl/source/app/IconThemeSelector.cxx index f7971dd17e1a..1a31f4158e81 100644 --- a/vcl/source/app/IconThemeSelector.cxx +++ b/vcl/source/app/IconThemeSelector.cxx @@ -30,7 +30,7 @@ namespace { private: const OUString& m_rThemeId; public: - SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} + explicit SameTheme(const OUString &rThemeId) : m_rThemeId(rThemeId) {} bool operator()(const vcl::IconThemeInfo &rInfo) { return m_rThemeId == rInfo.GetThemeId(); diff --git a/vcl/source/app/session.cxx b/vcl/source/app/session.cxx index 5db137f4d463..5686ec15f40b 100644 --- a/vcl/source/app/session.cxx +++ b/vcl/source/app/session.cxx @@ -56,7 +56,7 @@ class VCLSession: bool m_bInteractionDone; bool m_bSaveDone; - Listener( const css::uno::Reference< XSessionManagerListener >& xListener ) + explicit Listener( const css::uno::Reference< XSessionManagerListener >& xListener ) : m_xListener( xListener ), m_bInteractionRequested( false ), m_bInteractionDone( false ), diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx index fce2961c2c53..3f9026ed976e 100644 --- a/vcl/source/app/svmain.cxx +++ b/vcl/source/app/svmain.cxx @@ -206,7 +206,7 @@ static oslSignalHandler pExceptionHandler = NULL; class DesktopEnvironmentContext: public cppu::WeakImplHelper1< com::sun::star::uno::XCurrentContext > { public: - DesktopEnvironmentContext( const com::sun::star::uno::Reference< com::sun::star::uno::XCurrentContext > & ctx) + explicit DesktopEnvironmentContext( const com::sun::star::uno::Reference< com::sun::star::uno::XCurrentContext > & ctx) : m_xNextContext( ctx ) {} // XCurrentContext diff --git a/vcl/source/bitmap/bitmapscalesuper.cxx b/vcl/source/bitmap/bitmapscalesuper.cxx index 116b23355afd..2172aa53c0de 100644 --- a/vcl/source/bitmap/bitmapscalesuper.cxx +++ b/vcl/source/bitmap/bitmapscalesuper.cxx @@ -89,7 +89,7 @@ class ScaleTask : public comphelper::ThreadTask ScaleRangeFn mpFn; std::vector< ScaleRangeContext > maStrips; public: - ScaleTask( ScaleRangeFn pFn ) : mpFn( pFn ) {} + explicit ScaleTask( ScaleRangeFn pFn ) : mpFn( pFn ) {} void push( ScaleRangeContext &aRC ) { maStrips.push_back( aRC ); } virtual void doWork() SAL_OVERRIDE { diff --git a/vcl/source/control/quickselectionengine.cxx b/vcl/source/control/quickselectionengine.cxx index f9acf5bab956..2ed4d8e38e25 100644 --- a/vcl/source/control/quickselectionengine.cxx +++ b/vcl/source/control/quickselectionengine.cxx @@ -36,7 +36,7 @@ namespace vcl ::boost::optional< sal_Unicode > aSingleSearchChar; Timer aSearchTimeout; - QuickSelectionEngine_Data( ISearchableStringList& _entryList ) + explicit QuickSelectionEngine_Data( ISearchableStringList& _entryList ) :rEntryList( _entryList ) ,sCurrentSearchString() ,aSingleSearchChar() diff --git a/vcl/source/edit/textundo.hxx b/vcl/source/edit/textundo.hxx index ff24a0be872a..d51465eee90f 100644 --- a/vcl/source/edit/textundo.hxx +++ b/vcl/source/edit/textundo.hxx @@ -40,8 +40,8 @@ protected: TextView* GetView() const { return mpTextEngine->GetActiveView(); } public: - TextUndoManager( TextEngine* pTextEngine ); - virtual ~TextUndoManager(); + explicit TextUndoManager( TextEngine* pTextEngine ); + virtual ~TextUndoManager(); using SfxUndoManager::Undo; virtual bool Undo() SAL_OVERRIDE; @@ -65,7 +65,7 @@ protected: public: TYPEINFO_OVERRIDE(); - TextUndo( TextEngine* pTextEngine ); + explicit TextUndo( TextEngine* pTextEngine ); virtual ~TextUndo(); TextEngine* GetTextEngine() const { return mpTextEngine; } diff --git a/vcl/source/edit/textview.cxx b/vcl/source/edit/textview.cxx index 87afc813caee..679a983c21df 100644 --- a/vcl/source/edit/textview.cxx +++ b/vcl/source/edit/textview.cxx @@ -67,8 +67,8 @@ private: SvMemoryStream maHTMLStream; public: - TETextDataObject( const OUString& rText ); - virtual ~TETextDataObject(); + explicit TETextDataObject( const OUString& rText ); + virtual ~TETextDataObject(); OUString& GetText() { return maText; } SvMemoryStream& GetHTMLStream() { return maHTMLStream; } diff --git a/vcl/source/edit/vclmedit.cxx b/vcl/source/edit/vclmedit.cxx index 3b11cbb9b8a8..84bd57064455 100644 --- a/vcl/source/edit/vclmedit.cxx +++ b/vcl/source/edit/vclmedit.cxx @@ -46,7 +46,7 @@ private: bool mbTextSelectable; public: - TextWindow( vcl::Window* pParent ); + explicit TextWindow( vcl::Window* pParent ); virtual ~TextWindow(); virtual void dispose() SAL_OVERRIDE; diff --git a/vcl/source/filter/FilterConfigCache.hxx b/vcl/source/filter/FilterConfigCache.hxx index ee83a39db2fb..c288132a4ce2 100644 --- a/vcl/source/filter/FilterConfigCache.hxx +++ b/vcl/source/filter/FilterConfigCache.hxx @@ -119,7 +119,7 @@ public: bool IsExportInternalFilter( sal_uInt16 nFormat ); bool IsExportPixelFormat( sal_uInt16 nFormat ); - FilterConfigCache( bool bUseConfig ); + explicit FilterConfigCache( bool bUseConfig ); ~FilterConfigCache(); }; diff --git a/vcl/source/filter/graphicfilter.cxx b/vcl/source/filter/graphicfilter.cxx index a77e9739cae0..0a8afa2d0407 100644 --- a/vcl/source/filter/graphicfilter.cxx +++ b/vcl/source/filter/graphicfilter.cxx @@ -106,7 +106,7 @@ protected: public: - ImpFilterOutputStream( SvStream& rStm ) : mrStm( rStm ) {} + explicit ImpFilterOutputStream( SvStream& rStm ) : mrStm( rStm ) {} virtual ~ImpFilterOutputStream() {} }; diff --git a/vcl/source/filter/igif/decode.hxx b/vcl/source/filter/igif/decode.hxx index ee093bfaa2c5..4f5edde442cc 100644 --- a/vcl/source/filter/igif/decode.hxx +++ b/vcl/source/filter/igif/decode.hxx @@ -48,7 +48,7 @@ class GIFLZWDecompressor public: - GIFLZWDecompressor( sal_uInt8 cDataSize ); + explicit GIFLZWDecompressor( sal_uInt8 cDataSize ); ~GIFLZWDecompressor(); HPBYTE DecompressBlock( HPBYTE pSrc, sal_uInt8 cBufSize, sal_uLong& rCount, bool& rEOI ); diff --git a/vcl/source/filter/igif/gifread.hxx b/vcl/source/filter/igif/gifread.hxx index 5816fe54e6c2..dc161c2b31cb 100644 --- a/vcl/source/filter/igif/gifread.hxx +++ b/vcl/source/filter/igif/gifread.hxx @@ -106,7 +106,7 @@ public: ReadState ReadGIF( Graphic& rGraphic ); const Graphic& GetIntermediateGraphic(); - GIFReader( SvStream& rStm ); + explicit GIFReader( SvStream& rStm ); virtual ~GIFReader(); }; diff --git a/vcl/source/filter/ixbm/xbmread.hxx b/vcl/source/filter/ixbm/xbmread.hxx index 4f3b52e7e8af..55e1a9638e8e 100644 --- a/vcl/source/filter/ixbm/xbmread.hxx +++ b/vcl/source/filter/ixbm/xbmread.hxx @@ -51,18 +51,18 @@ class XBMReader : public GraphicReader long nHeight; bool bStatus; - void InitTable(); - OString FindTokenLine( SvStream* pInStm, const char* pTok1, + void InitTable(); + OString FindTokenLine( SvStream* pInStm, const char* pTok1, const char* pTok2 = NULL, const char* pTok3 = NULL ); - long ParseDefine( const sal_Char* pDefine ); + long ParseDefine( const sal_Char* pDefine ); bool ParseData( SvStream* pInStm, const OString& aLastLine, XBMFormat eFormat ); public: - XBMReader( SvStream& rStm ); - virtual ~XBMReader(); + explicit XBMReader( SvStream& rStm ); + virtual ~XBMReader(); - ReadState ReadXBM( Graphic& rGraphic ); + ReadState ReadXBM( Graphic& rGraphic ); }; #endif // _XBMPRIVATE diff --git a/vcl/source/filter/ixpm/xpmread.hxx b/vcl/source/filter/ixpm/xpmread.hxx index 0c9b9d314446..14543ca7d9fd 100644 --- a/vcl/source/filter/ixpm/xpmread.hxx +++ b/vcl/source/filter/ixpm/xpmread.hxx @@ -95,7 +95,7 @@ private: sal_uLong ImplGetULONG( sal_uLong nPara ); public: - XPMReader( SvStream& rStm ); + explicit XPMReader( SvStream& rStm ); virtual ~XPMReader(); ReadState ReadXPM( Graphic& rGraphic ); diff --git a/vcl/source/filter/wmf/emfwr.hxx b/vcl/source/filter/wmf/emfwr.hxx index d037bdeb9d6c..80fc6e39ec89 100644 --- a/vcl/source/filter/wmf/emfwr.hxx +++ b/vcl/source/filter/wmf/emfwr.hxx @@ -89,7 +89,7 @@ private: public: - EMFWriter(SvStream &rStream) + explicit EMFWriter(SvStream &rStream) : maVDev( VclPtr<VirtualDevice>::Create() ) , m_rStm(rStream) , mpHandlesUsed(NULL) diff --git a/vcl/source/filter/wmf/winmtf.hxx b/vcl/source/filter/wmf/winmtf.hxx index d50fb3788e18..babad4ebbffd 100644 --- a/vcl/source/filter/wmf/winmtf.hxx +++ b/vcl/source/filter/wmf/winmtf.hxx @@ -287,7 +287,7 @@ struct WinMtfFontStyle { vcl::Font aFont; - WinMtfFontStyle( LOGFONTW& rLogFont ); + explicit WinMtfFontStyle( LOGFONTW& rLogFont ); }; @@ -316,7 +316,7 @@ struct WinMtfFillStyle , aType(FillStyleSolid) {} - WinMtfFillStyle(Bitmap& rBmp) + explicit WinMtfFillStyle(Bitmap& rBmp) : bTransparent(false) , aType(FillStylePattern) , aBmp(rBmp) @@ -718,7 +718,7 @@ public: void PassEMFPlus( void* pBuffer, sal_uInt32 nLength ); void PassEMFPlusHeaderInfo(); - WinMtfOutput( GDIMetaFile& rGDIMetaFile ); + explicit WinMtfOutput( GDIMetaFile& rGDIMetaFile ); virtual ~WinMtfOutput(); }; diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx index dfd5d2056c99..ede244c752d3 100644 --- a/vcl/source/fontsubset/sft.cxx +++ b/vcl/source/fontsubset/sft.cxx @@ -75,7 +75,7 @@ struct PSPathElement int x2, y2; int x3, y3; - PSPathElement( PathSegmentType i_eType ) : type( i_eType ), + explicit PSPathElement( PathSegmentType i_eType ) : type( i_eType ), x1( 0 ), y1( 0 ), x2( 0 ), y2( 0 ), x3( 0 ), y3( 0 ) diff --git a/vcl/source/gdi/bmpfast.cxx b/vcl/source/gdi/bmpfast.cxx index 10348c9029f2..10d18bacc878 100644 --- a/vcl/source/gdi/bmpfast.cxx +++ b/vcl/source/gdi/bmpfast.cxx @@ -30,7 +30,7 @@ typedef unsigned char PIXBYTE; class BasePixelPtr { public: - BasePixelPtr( PIXBYTE* p = NULL ) : mpPixel( p ) {} + explicit BasePixelPtr( PIXBYTE* p = NULL ) : mpPixel( p ) {} void SetRawPtr( PIXBYTE* pRawPtr ) { mpPixel = pRawPtr; } PIXBYTE* GetRawPtr() const { return mpPixel; } void AddByteOffset( int nByteOffset ) { mpPixel += nByteOffset; } diff --git a/vcl/source/gdi/pdfextoutdevdata.cxx b/vcl/source/gdi/pdfextoutdevdata.cxx index 3cab7d14dc76..ca695480cbdb 100644 --- a/vcl/source/gdi/pdfextoutdevdata.cxx +++ b/vcl/source/gdi/pdfextoutdevdata.cxx @@ -300,7 +300,7 @@ struct PageSyncData bool mbGroupIgnoreGDIMtfActions; - PageSyncData( GlobalSyncData* pGlobal ) : mbGroupIgnoreGDIMtfActions ( false ) { mpGlobalData = pGlobal; } + explicit PageSyncData( GlobalSyncData* pGlobal ) : mbGroupIgnoreGDIMtfActions ( false ) { mpGlobalData = pGlobal; } void PushAction( const OutputDevice& rOutDev, const PDFExtOutDevDataSync::Action eAct ); bool PlaySyncPageAct( PDFWriter& rWriter, sal_uInt32& rCurGDIMtfAction, const PDFExtOutDevData& rOutDevData ); diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 99433c2d053e..37ab711f393d 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -2245,7 +2245,7 @@ private: public: enum {PDF_FONT_MAGIC = 0xBDFF0A1C }; - ImplPdfBuiltinFontData( const PDFWriterImpl::BuiltinFont& ); + explicit ImplPdfBuiltinFontData( const PDFWriterImpl::BuiltinFont& ); const PDFWriterImpl::BuiltinFont& GetBuiltinFont() const { return mrBuiltin; } virtual PhysicalFontFace* Clone() const SAL_OVERRIDE { return new ImplPdfBuiltinFontData(*this); } @@ -6051,7 +6051,7 @@ char *PDFSigningPKCS7PasswordCallback(PK11SlotInfo * /*slot*/, PRBool /*retry*/, class HashContextScope { HASHContext *mpPtr; public: - HashContextScope(HASHContext *pPtr) : mpPtr(pPtr) {} + explicit HashContextScope(HASHContext *pPtr) : mpPtr(pPtr) {} ~HashContextScope() { clear(); } void clear() { if (mpPtr) { HASH_Destroy(mpPtr); } mpPtr = NULL; } HASHContext *get() { return mpPtr; } @@ -8181,7 +8181,7 @@ struct AnnotSorterLess { std::vector< PDFWriterImpl::PDFWidget >& m_rWidgets; - AnnotSorterLess( std::vector< PDFWriterImpl::PDFWidget >& rWidgets ) : m_rWidgets( rWidgets ) {} + explicit AnnotSorterLess( std::vector< PDFWriterImpl::PDFWidget >& rWidgets ) : m_rWidgets( rWidgets ) {} bool operator()( const AnnotationSortEntry& rLeft, const AnnotationSortEntry& rRight ) { @@ -8270,7 +8270,7 @@ class PDFStreamIf : PDFWriterImpl* m_pWriter; bool m_bWrite; public: - PDFStreamIf( PDFWriterImpl* pWriter ) : m_pWriter( pWriter ), m_bWrite( true ) {} + explicit PDFStreamIf( PDFWriterImpl* pWriter ) : m_pWriter( pWriter ), m_bWrite( true ) {} virtual ~PDFStreamIf(); virtual void SAL_CALL writeBytes( const com::sun::star::uno::Sequence< sal_Int8 >& aData ) throw(std::exception) SAL_OVERRIDE; @@ -10785,7 +10785,7 @@ class AccessReleaser { BitmapReadAccess* m_pAccess; public: - AccessReleaser( BitmapReadAccess* pAccess ) : m_pAccess( pAccess ){} + explicit AccessReleaser( BitmapReadAccess* pAccess ) : m_pAccess( pAccess ){} ~AccessReleaser() { delete m_pAccess; } }; diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 226359690ae7..090a70c9e570 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -694,7 +694,7 @@ class sortButtons { bool m_bVerticalContainer; public: - sortButtons(bool bVerticalContainer) + explicit sortButtons(bool bVerticalContainer) : m_bVerticalContainer(bVerticalContainer) { } diff --git a/vcl/source/window/menubarwindow.hxx b/vcl/source/window/menubarwindow.hxx index 0ebb19a65b35..23d87415a37f 100644 --- a/vcl/source/window/menubarwindow.hxx +++ b/vcl/source/window/menubarwindow.hxx @@ -111,7 +111,7 @@ private: void GetFocus() SAL_OVERRIDE; public: - MenuBarWindow( vcl::Window* pParent ); + explicit MenuBarWindow( vcl::Window* pParent ); virtual ~MenuBarWindow(); virtual void dispose() SAL_OVERRIDE; diff --git a/vcl/source/window/mnemonicengine.cxx b/vcl/source/window/mnemonicengine.cxx index 3fbf5923c4d1..f9f74398e172 100644 --- a/vcl/source/window/mnemonicengine.cxx +++ b/vcl/source/window/mnemonicengine.cxx @@ -30,7 +30,7 @@ namespace vcl { IMnemonicEntryList& rEntryList; - MnemonicEngine_Data( IMnemonicEntryList& _rEntryList ) + explicit MnemonicEngine_Data( IMnemonicEntryList& _rEntryList ) :rEntryList( _rEntryList ) { } diff --git a/vcl/source/window/openglwin.cxx b/vcl/source/window/openglwin.cxx index 30094e439b5d..46628c6d7929 100644 --- a/vcl/source/window/openglwin.cxx +++ b/vcl/source/window/openglwin.cxx @@ -15,7 +15,7 @@ class OpenGLWindowImpl { public: - OpenGLWindowImpl(vcl::Window* pWindow); + explicit OpenGLWindowImpl(vcl::Window* pWindow); ~OpenGLWindowImpl() { mxChildWindow.disposeAndClear(); } OpenGLContext& getContext() { return maContext;} private: diff --git a/vcl/source/window/scrwnd.hxx b/vcl/source/window/scrwnd.hxx index 2db56ce4d053..8ce1c6b3a131 100644 --- a/vcl/source/window/scrwnd.hxx +++ b/vcl/source/window/scrwnd.hxx @@ -69,7 +69,7 @@ protected: public: - ImplWheelWindow( vcl::Window* pParent ); + explicit ImplWheelWindow( vcl::Window* pParent ); virtual ~ImplWheelWindow(); virtual void dispose() SAL_OVERRIDE; |