summaryrefslogtreecommitdiff
path: root/vcl/source/window/floatwin.cxx
diff options
context:
space:
mode:
authorMarco Cecchetti <marco.cecchetti@collabora.com>2018-04-27 21:51:41 +0200
committerJan Holesovsky <kendy@collabora.com>2018-05-23 16:13:47 +0200
commit32ebfd0da5da80a2fc7b92469024585f1d49bb16 (patch)
tree356c7509b37430b58d7e56cbabe8d9e4cfe37dc7 /vcl/source/window/floatwin.cxx
parent249e93db8aaa25398eda29cc8292c1d707afacad (diff)
lok: sc: tunneling the ascii import dialog on paste action
I needed to modify CreateScImportAsciiDlg signature so that we are able to pass a pointer to a dialog parent window to ScImportAsciiDlg. Moreover, I needed to perform the execution of the ScImportAsciiDlg dialog in ScViewFunc::PasteDataFormat asynchronously, both for lok and desktop case. In order to achieve this result it has been needed to modify the lifespan of some objects previously local to PasteDataFormat. Since PasteDataFormat returns a boolean, I took care to check how this return value is used. I found out 2 cases: 1) in ScViewFunc::PasteFromSystem where it is used for popping up an error dialog box, informing the user in the case that the paste operation is failed; 2) in ScGridWindow::ExecuteDrop where it is used for informing the system window manager of the success or fail of the drag and drop action. The first case is now handled by a lamba invoked soon after the dialog execution ended. The second case is more tricky: I handle it as the paste operation is always successful, hoping it doesn't do any real difference since the return value is used not by LO but by the system window manager (e.g. gtk). The asynchronous call and the behaviors described above occur only when the paste operation involves some kind of simple text, in all other cases nothing is changed. Change-Id: Id4f96180a9336f665a22a2441ea490af993431b0 Reviewed-on: https://gerrit.libreoffice.org/53931 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'vcl/source/window/floatwin.cxx')
0 files changed, 0 insertions, 0 deletions