diff options
| author | Jan-Marek Glogowski <glogow@fbihome.de> | 2017-08-29 10:29:51 +0200 |
|---|---|---|
| committer | Jan-Marek Glogowski <glogow@fbihome.de> | 2017-09-26 13:53:28 +0200 |
| commit | 9679fb26558ea42e47ac9936cef329115a8fdf65 (patch) | |
| tree | eee6c65d50667fc5b9924f98ce8f87a6df9d707a /vcl/source/app/svapp.cxx | |
| parent | 808d048694630303d895e818cfd5fb48c9d16738 (diff) | |
tdf#112288 Clarify Reschedule implementations
Application::Reschedule(true) must just process all currently
pending events and ignore all new events generated while processing
them. In contrast to Scheduler::ProcessEventsToIdle, this way it
can't busy-lock the application with background jobs.
This way we also can drop nMaxEvents from the Windows backend. This
limit was also never implemented on OSX and for the KDE4 backend
it's actually impossible to handle single events, and a call to
QAbstractEventDispatcher::processEvents works like this.
Also changes various call sites to just process all pending events
instead of some made up number of times.
Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c
Reviewed-on: https://gerrit.libreoffice.org/42659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Diffstat (limited to 'vcl/source/app/svapp.cxx')
| -rw-r--r-- | vcl/source/app/svapp.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx index 612fce86bc2f..be09136b1717 100644 --- a/vcl/source/app/svapp.cxx +++ b/vcl/source/app/svapp.cxx @@ -488,7 +488,7 @@ bool Application::Reschedule( bool i_bAllEvents ) void Scheduler::ProcessEventsToSignal(bool& bSignal) { - while (!bSignal && Application::Reschedule( false ) ); + while (!bSignal && Application::Reschedule() ); } void Scheduler::ProcessEventsToIdle() @@ -516,7 +516,8 @@ void Scheduler::ProcessEventsToIdle() Idle *pIdle = dynamic_cast<Idle*>( pSchedulerData->mpTask ); if ( pIdle && pIdle->IsActive() ) { - SAL_WARN( "vcl.schedule", "Unprocessed Idle: " << pIdle->GetDebugName() ); + SAL_WARN( "vcl.schedule", "Unprocessed Idle: " + << pIdle << " " << pIdle->GetDebugName() ); } } pSchedulerData = pSchedulerData->mpNext; |