summaryrefslogtreecommitdiff
path: root/vcl/Library_vcl.mk
diff options
context:
space:
mode:
authorDennis Francis <dennis.francis@collabora.com>2019-06-23 21:15:18 +0530
committerLuboš Luňák <l.lunak@collabora.com>2019-06-24 10:58:01 +0200
commit46c8ebe3d352c39bbba1a8099717fbeba384bd1a (patch)
tree70b429a066c3779ba56f8cfc4239700507c4e543 /vcl/Library_vcl.mk
parent7639b4e6d8b3f51c1a5027be8a5b6f146d78b08d (diff)
tdf#125661 : Move the delayed-grouping logic...
introduced in commit 169a1b542165f3444791fd6e672d56d3fe48bd66 avoid possible expensive repetitive formula-group changes (tdf#102364) to ScTable::CopyToTable() from ScDocument::CopyToDocument() Rationale : In tdf#125661 a delayed-grouping is needed but ScDocument::CopyTab() is directly called which makes it skip the delayed-grouping logic in ScDocument::CopyToDocument(). One option is to clone the delayed-grouping logic to CopyTab() too. But doing this triggers the assert !pDoc->IsDelayedFormulaGrouping() in bool ScBroadcastAreaSlot::StartListeningArea() when running the unit test testCondCopyPasteSheet() in ucalc_condformat.cxx. This seems to be due to calling ScTable::CopyConditionalFormat() towards the end in ScTable::CopyToTable(). So having delayed-grouping "block" that contains a call(s) to ScTable::CopyToTable() is not safe. So lets move this inside ScTable::CopyToTable() covering just the ScColumn::CopyToColumn() calls. With this patch, sheet copy on the bug-document completes in about 1m40s. Change-Id: I5272f495aadab5f93f2698aba11cf2701a604c23 Reviewed-on: https://gerrit.libreoffice.org/74607 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'vcl/Library_vcl.mk')
0 files changed, 0 insertions, 0 deletions