use more OUString::operator== in test..xmlsecurity

Change-Id: If5bdd1532be44a47ff7cc3b769be3ea585aea562
Reviewed-on: https://gerrit.libreoffice.org/39685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 7 insertions, 8 deletions

diff --git a/vbahelper/source/msforms/vbacombobox.cxx b/vbahelper/source/msforms/vbacombobox.cxx
index 62033556ec48..a026816e4e27 100644
--- a/vbahelper/source/msforms/vbacombobox.cxx
+++ b/vbahelper/source/msforms/vbacombobox.cxx
@@ -97,7 +97,7 @@ ScVbaComboBox::getListIndex()
         sal_Int32 nLen = sItems.getLength();
         for ( sal_Int32 index = 0; !sText.isEmpty() && index < nLen; ++index )
         {
-            if ( sItems[ index ].equals( sText ) )
+            if ( sItems[ index ] == sText )
             {
                 SAL_INFO("vbahelper", "getListIndex returning " << index );
                 return uno::makeAny( index );
diff --git a/vbahelper/source/msforms/vbalistbox.cxx b/vbahelper/source/msforms/vbalistbox.cxx
index da94a1097fe4..58e8d3acbe28 100644
--- a/vbahelper/source/msforms/vbalistbox.cxx
+++ b/vbahelper/source/msforms/vbalistbox.cxx
@@ -83,7 +83,7 @@ ScVbaListBox::setValue( const uno::Any& _value )
     sal_Int16 i = 0;
     for( i = 0; i < nLength; i++ )
     {
-        if( sList[i].equals( sValue ) )
+        if( sList[i] == sValue )
         {
             nValue = i;
             break;
diff --git a/vbahelper/source/vbahelper/vbaglobalbase.cxx b/vbahelper/source/vbahelper/vbaglobalbase.cxx
index 3d90fa37d181..2eaa8ea9d66f 100644
--- a/vbahelper/source/vbahelper/vbaglobalbase.cxx
+++ b/vbahelper/source/vbahelper/vbaglobalbase.cxx
@@ -107,7 +107,7 @@ VbaGlobalsBase::init(  const uno::Sequence< beans::PropertyValue >& aInitArgs )
     for ( sal_Int32 nIndex = 0; nIndex < nLen; ++nIndex )
     {
         uno::Reference< container::XNameContainer > xNameContainer( mxContext, uno::UNO_QUERY_THROW );
-        if ( aInitArgs[ nIndex ].Name.equals( msApplication ) )
+        if ( aInitArgs[ nIndex ].Name == msApplication )
         {
             xNameContainer->replaceByName( msApplication, aInitArgs[ nIndex ].Value );
             uno::Reference< XHelperInterface > xParent( aInitArgs[ nIndex ].Value, uno::UNO_QUERY );
@@ -163,7 +163,7 @@ VbaGlobalsBase::hasServiceName( const OUString& serviceName )
     sal_Int32 nLen = sServiceNames.getLength();
     for ( sal_Int32 index = 0; index < nLen; ++index )
     {
-        if ( sServiceNames[ index ].equals( serviceName ) )
+        if ( sServiceNames[ index ] == serviceName )
             return true;
     }
     return false;
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx
index 272608c2a11c..d1b68f198503 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -534,8 +534,7 @@ ContainerUtilities::FieldInList( const uno::Sequence< OUString >& SearchList, co
     {
         // I wonder why comparing lexicographically is done
         // when it's a match is whats interesting?
-        //if (SearchList[i].compareTo(SearchString) == 0)
-        if ( SearchList[i].equals( SearchString ) )
+        if ( SearchList[i] == SearchString )
         {
             retvalue = i;
             break;
@@ -752,7 +751,7 @@ uno::Any getPropertyValue( const uno::Sequence< beans::PropertyValue >& aProp, c
 {
     for ( sal_Int32 i = 0; i < aProp.getLength(); i++ )
     {
-        if ( aProp[i].Name.equals(aName) )
+        if ( aProp[i].Name == aName )
         {
             return aProp[i].Value;
         }
@@ -764,7 +763,7 @@ bool setPropertyValue( uno::Sequence< beans::PropertyValue >& aProp, const OUStr
 {
     for ( sal_Int32 i = 0; i < aProp.getLength(); i++ )
     {
-        if ( aProp[i].Name.equals(aName) )
+        if ( aProp[i].Name == aName )
         {
             aProp[i].Value = aValue;
             return true;