summaryrefslogtreecommitdiff
path: root/vbahelper
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2016-11-07 09:31:52 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2016-11-07 10:11:33 +0000
commit0f96b3f33f98ecd56f0fe55a65315d6762ff978a (patch)
treefa4f2b9dd0b7e8e9f30d6fe18c86a3e89a66352f /vbahelper
parent41ea741cd843776cd600d33b28a7f0e35345e0d0 (diff)
loplugin:unnecessaryvirtual in test..vbahelper
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vbahelper')
-rw-r--r--vbahelper/source/msforms/vbalistcontrolhelper.hxx3
-rw-r--r--vbahelper/source/vbahelper/vbaapplicationbase.cxx6
-rw-r--r--vbahelper/source/vbahelper/vbacommandbarhelper.cxx3
3 files changed, 5 insertions, 7 deletions
diff --git a/vbahelper/source/msforms/vbalistcontrolhelper.hxx b/vbahelper/source/msforms/vbalistcontrolhelper.hxx
index ad580f4812da..e60b52b9a133 100644
--- a/vbahelper/source/msforms/vbalistcontrolhelper.hxx
+++ b/vbahelper/source/msforms/vbalistcontrolhelper.hxx
@@ -22,13 +22,12 @@
#include <vbahelper/vbahelper.hxx>
-class ListControlHelper
+class ListControlHelper final
{
css::uno::Reference< css::beans::XPropertySet > m_xProps;
public:
explicit ListControlHelper( const css::uno::Reference< css::beans::XPropertySet >& rxControl ) : m_xProps( rxControl ){}
- virtual ~ListControlHelper() {}
void SAL_CALL AddItem( const css::uno::Any& pvargItem, const css::uno::Any& pvargIndex ) throw (css::uno::RuntimeException);
void SAL_CALL removeItem( const css::uno::Any& index ) throw (css::uno::RuntimeException);
void SAL_CALL setRowSource( const OUString& _rowsource ) throw (css::uno::RuntimeException);
diff --git a/vbahelper/source/vbahelper/vbaapplicationbase.cxx b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
index 80ef3040a93d..d505da474560 100644
--- a/vbahelper/source/vbahelper/vbaapplicationbase.cxx
+++ b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
@@ -69,7 +69,7 @@ public:
VbaTimer()
{}
- virtual ~VbaTimer()
+ ~VbaTimer()
{
m_aTimer.Stop();
}
@@ -151,14 +151,14 @@ struct VbaTimerInfoHash
typedef std::unordered_map< VbaTimerInfo, VbaTimer*, VbaTimerInfoHash > VbaTimerHashMap;
// ====VbaApplicationBase_Impl==================================
-struct VbaApplicationBase_Impl
+struct VbaApplicationBase_Impl final
{
VbaTimerHashMap m_aTimerHash;
bool mbVisible;
inline VbaApplicationBase_Impl() : mbVisible( true ) {}
- virtual ~VbaApplicationBase_Impl()
+ ~VbaApplicationBase_Impl()
{
// remove the remaining timers
for ( VbaTimerHashMap::iterator aIter = m_aTimerHash.begin();
diff --git a/vbahelper/source/vbahelper/vbacommandbarhelper.cxx b/vbahelper/source/vbahelper/vbacommandbarhelper.cxx
index 8bd5fb02a6b6..5c82007317ae 100644
--- a/vbahelper/source/vbahelper/vbacommandbarhelper.cxx
+++ b/vbahelper/source/vbahelper/vbacommandbarhelper.cxx
@@ -38,7 +38,7 @@ using namespace ooo::vba;
typedef std::map< OUString, OUString > MSO2OOCommandbarMap;
-class MSO2OOCommandbarHelper
+class MSO2OOCommandbarHelper final
{
private:
static MSO2OOCommandbarHelper* pMSO2OOCommandbarHelper;
@@ -61,7 +61,6 @@ private:
}
public:
- virtual ~MSO2OOCommandbarHelper() {};
static MSO2OOCommandbarHelper* getMSO2OOCommandbarHelper()
{
if( pMSO2OOCommandbarHelper == nullptr )