uui: prefer passing OUString by reference

Change-Id: Iec1fb3fd063d73f04a1600a21d6129e4cd5476b4

6 files changed, 8 insertions, 7 deletions

diff --git a/uui/source/iahndl-authentication.cxx b/uui/source/iahndl-authentication.cxx
index 2050f382e9d0..ae579e6a6661 100644
--- a/uui/source/iahndl-authentication.cxx
+++ b/uui/source/iahndl-authentication.cxx
@@ -507,7 +507,7 @@ executePasswordDialog(
     Window * pParent,
     LoginErrorInfo & rInfo,
     task::PasswordRequestMode nMode,
-    OUString aDocName,
+    const OUString& aDocName,
     bool bMSCryptoMode,
     bool bIsPasswordToModify,
     bool bIsSimplePasswordRequest )
@@ -569,7 +569,7 @@ handlePasswordRequest_(
     task::PasswordRequestMode nMode,
     uno::Sequence< uno::Reference< task::XInteractionContinuation > > const &
         rContinuations,
-    OUString aDocumentName,
+    const OUString& aDocumentName,
     bool bMSCryptoMode,
     bool bIsPasswordToModify,
     bool bIsSimplePasswordRequest = false )
diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index feb21f27e24b..f51efa156c4a 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -80,7 +80,7 @@ getContentPart( const OUString& _rRawString )
 
 bool
 isDomainMatch(
-              OUString hostName, uno::Sequence< OUString > certHostNames)
+              const OUString& hostName, uno::Sequence< OUString > certHostNames)
 {
     for ( int i = 0; i < certHostNames.getLength(); i++){
         OUString element = certHostNames[i];
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx
index 907fa49ca51c..13bbb7e2dd44 100644
--- a/uui/source/iahndl.cxx
+++ b/uui/source/iahndl.cxx
@@ -257,9 +257,10 @@ UUIInteractionHelper::getStringFromRequest(
 
 OUString
 UUIInteractionHelper::replaceMessageWithArguments(
-    OUString aMessage,
+    const OUString& _aMessage,
     std::vector< OUString > const & rArguments )
 {
+    OUString aMessage = _aMessage;
     for (sal_Int32 i = 0;;)
     {
         i = aMessage.indexOf("$(ARG", i);
diff --git a/uui/source/iahndl.hxx b/uui/source/iahndl.hxx
index be740d0b2a68..44b19120d26b 100644
--- a/uui/source/iahndl.hxx
+++ b/uui/source/iahndl.hxx
@@ -122,7 +122,7 @@ public:
     // Helper.
     static OUString
     replaceMessageWithArguments(
-        OUString aMessage,
+        const OUString& aMessage,
             std::vector< OUString > const & rArguments );
 
     ::com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >
diff --git a/uui/source/passworddlg.cxx b/uui/source/passworddlg.cxx
index 6d6bc023071d..91e05e09eacc 100644
--- a/uui/source/passworddlg.cxx
+++ b/uui/source/passworddlg.cxx
@@ -27,7 +27,7 @@ using namespace ::com::sun::star;
 
 PasswordDialog::PasswordDialog(Window* _pParent,
     task::PasswordRequestMode nDlgMode, ResMgr * pResMgr,
-    OUString& aDocURL, bool bOpenToModify, bool bIsSimplePasswordRequest)
+    const OUString& aDocURL, bool bOpenToModify, bool bIsSimplePasswordRequest)
     : ModalDialog(_pParent, "PasswordDialog", "uui/ui/password.ui")
     , nMinLen(1)
     , aPasswdMismatch(ResId(STR_PASSWORD_MISMATCH, *pResMgr))
diff --git a/uui/source/passworddlg.hxx b/uui/source/passworddlg.hxx
index bb5a592165b2..4d7c03d975cf 100644
--- a/uui/source/passworddlg.hxx
+++ b/uui/source/passworddlg.hxx
@@ -44,7 +44,7 @@ class PasswordDialog : public ModalDialog
     DECL_LINK(OKHdl_Impl, void *);
 
 public:
-    PasswordDialog( Window* pParent, ::com::sun::star::task::PasswordRequestMode nDlgMode, ResMgr * pResMgr, OUString& aDocURL,
+    PasswordDialog( Window* pParent, ::com::sun::star::task::PasswordRequestMode nDlgMode, ResMgr * pResMgr, const OUString& aDocURL,
             bool bOpenToModify = false, bool bIsSimplePasswordRequest = false );
 
     void            SetMinLen( sal_uInt16 nMin ) { nMinLen = nMin; }