diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /unoidl | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'unoidl')
| -rw-r--r-- | unoidl/source/sourceprovider-scanner.hxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/unoidl/source/sourceprovider-scanner.hxx b/unoidl/source/sourceprovider-scanner.hxx index 14ac15421f08..614340e41b48 100644 --- a/unoidl/source/sourceprovider-scanner.hxx +++ b/unoidl/source/sourceprovider-scanner.hxx @@ -58,7 +58,7 @@ private: class SourceProviderPlainStructTypeEntityPad: public SourceProviderEntityPad { public: SourceProviderPlainStructTypeEntityPad( - bool published, OUString theBaseName, + bool published, const OUString & theBaseName, rtl::Reference<unoidl::PlainStructTypeEntity> const & theBaseEntity): SourceProviderEntityPad(published), baseName(theBaseName), baseEntity(theBaseEntity) @@ -90,7 +90,7 @@ private: class SourceProviderExceptionTypeEntityPad: public SourceProviderEntityPad { public: SourceProviderExceptionTypeEntityPad( - bool published, OUString theBaseName, + bool published, const OUString & theBaseName, rtl::Reference<unoidl::ExceptionTypeEntity> const & theBaseEntity): SourceProviderEntityPad(published), baseName(theBaseName), baseEntity(theBaseEntity) @@ -128,7 +128,7 @@ public: OUString mandatory; std::set<OUString> optional; - explicit Member(OUString theMandatory): mandatory(theMandatory) {} + explicit Member(const OUString & theMandatory): mandatory(theMandatory) {} }; SourceProviderInterfaceTypeEntityPad(bool published, bool theSingleBase): |