loplugin:referencecasting in ucb

Change-Id: I7531ea30e8d141dce1d1bc27ffbca3fcf28d0ef5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 11 insertions, 12 deletions

diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
index 97205dd14a81..4a239bd80d07 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
@@ -73,7 +73,7 @@ int DAVAuthListener_Impl::authenticate(
                 = new ucbhelper::SimpleAuthenticationRequest(
                     m_aURL, inHostName, inRealm, inoutUserName,
                     outPassWord, bCanUseSystemCredentials );
-            xIH->handle( xRequest.get() );
+            xIH->handle( xRequest );
 
             rtl::Reference< ucbhelper::InteractionContinuation > xSelection
                 = xRequest->getSelection();
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index b914f41cd903..3c5dbf0398ca 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -505,7 +505,7 @@ int NeonSession::CertificationNotify(const ne_ssl_certificate *cert)
             rtl::Reference< ucbhelper::SimpleCertificateValidationRequest >
                 xRequest( new ucbhelper::SimpleCertificateValidationRequest(
                     static_cast<sal_Int32>(certValidity), xEECert, getHostName() ) );
-            xIH->handle( xRequest.get() );
+            xIH->handle( xRequest );
 
             rtl::Reference< ucbhelper::InteractionContinuation > xSelection
                 = xRequest->getSelection();
@@ -1210,7 +1210,7 @@ NeonSession::GET( const OUString & inPath,
 
     HandleError( theRetVal, inPath, rEnv );
 
-    return uno::Reference< io::XInputStream >( xInputStream.get() );
+    return xInputStream;
 }
 
 void NeonSession::GET( const OUString & inPath,
@@ -1258,7 +1258,7 @@ NeonSession::GET( const OUString & inPath,
 
     HandleError( theRetVal, inPath, rEnv );
 
-    return uno::Reference< io::XInputStream >( xInputStream.get() );
+    return xInputStream;
 }
 
 void NeonSession::GET0( const OUString & inPath,
@@ -1363,7 +1363,7 @@ NeonSession::POST( const OUString & inPath,
 
     HandleError( theRetVal, inPath, rEnv );
 
-    return uno::Reference< io::XInputStream >( xInputStream.get() );
+    return xInputStream;
 }
 
 void NeonSession::POST( const OUString & inPath,
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index e73547af427b..472366469c76 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -1247,7 +1247,7 @@ uno::Reference< sdbc::XRow > Content::getPropertyValues(
         xRow->appendPropertySet( xSet );
     }
 
-    return uno::Reference< sdbc::XRow >( xRow.get() );
+    return xRow;
 }
 
 namespace {
@@ -1307,7 +1307,7 @@ uno::Reference< sdbc::XRow > Content::getPropertyValues(
 
         aUnescapedTitle = NeonUri::unescape( m_aEscapedTitle );
         xIdentifier.set( m_xIdentifier );
-        xProvider.set( m_xProvider.get() );
+        xProvider = m_xProvider;
         xResAccess.reset(new DAVResourceAccess(*m_xResAccess));
 
         // First, ask cache...
@@ -2480,7 +2480,7 @@ void Content::insert(
                 = new ucbhelper::SimpleInteractionRequest(
                     aExAsAny,
                     ContinuationFlags::Approve | ContinuationFlags::Disapprove );
-            xIH->handle( xRequest.get() );
+            xIH->handle( xRequest );
 
             const ContinuationFlags nResp = xRequest->getResponse();
 
@@ -2677,7 +2677,7 @@ void Content::transfer(
         osl::Guard< osl::Mutex > aGuard( m_aMutex );
 
         xIdentifier.set( m_xIdentifier );
-        xProvider.set( m_xProvider.get() );
+        xProvider = m_xProvider;
         xResAccess.reset(new DAVResourceAccess(*m_xResAccess));
     }
 
diff --git a/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx b/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
index b87d987752fb..6acadda6a6fd 100644
--- a/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavdatasupplier.cxx
@@ -295,8 +295,7 @@ uno::Reference< sdbc::XRow > DataSupplier::queryPropertyValues(
                 m_pImpl->m_xContext,
                 getResultSet()->getProperties(),
                 *(m_pImpl->m_Results[ nIndex ]->pData),
-                rtl::Reference< ::ucbhelper::ContentProviderImplHelper >(
-                    m_pImpl->m_xContent->getProvider().get() ),
+                m_pImpl->m_xContent->getProvider(),
                 queryContentIdentifierString( nIndex ) );
         m_pImpl->m_Results[ nIndex ]->xRow = xRow;
         return xRow;
diff --git a/ucb/source/ucp/webdav-neon/webdavprovider.cxx b/ucb/source/ucp/webdav-neon/webdavprovider.cxx
index e63fd5c9d40a..55d8619a94aa 100644
--- a/ucb/source/ucp/webdav-neon/webdavprovider.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavprovider.cxx
@@ -156,7 +156,7 @@ ContentProvider::queryContent(
 
     // Check, if a content with given id already exists...
     uno::Reference< ucb::XContent > xContent
-        = queryExistingContent( xCanonicId ).get();
+        = queryExistingContent( xCanonicId );
     if ( xContent.is() )
         return xContent;