summaryrefslogtreecommitdiff
path: root/ucb/qa
diff options
context:
space:
mode:
authorGiuseppe Castagno <giuseppe.castagno@acca-esse.eu>2016-10-26 08:57:51 +0200
committerGiuseppe Castagno <giuseppe.castagno@acca-esse.eu>2016-10-26 08:49:53 +0000
commit80cd32f78deca3fea2f731af02a2ad83134261f3 (patch)
treeb596d5faf2528f6f096ae923baf3f4404ab138c1 /ucb/qa
parentc498c97f7457fe7ef34164a822c9a1e2f04e9b1d (diff)
WebDAV: Small cosmetic to unit checks.
Change server name in URI test strings. Pass by const lvalue reference [loplugin:passstuffbyref]. Change-Id: Ic0134f0690a8e6b9abb7d0764efaeeaf3a167bcf Reviewed-on: https://gerrit.libreoffice.org/30284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Diffstat (limited to 'ucb/qa')
-rw-r--r--ucb/qa/cppunit/webdav/webdav_options.cxx14
1 files changed, 7 insertions, 7 deletions
diff --git a/ucb/qa/cppunit/webdav/webdav_options.cxx b/ucb/qa/cppunit/webdav/webdav_options.cxx
index ce3aba7895e3..b1a71ba09b3d 100644
--- a/ucb/qa/cppunit/webdav/webdav_options.cxx
+++ b/ucb/qa/cppunit/webdav/webdav_options.cxx
@@ -27,7 +27,7 @@ namespace
void tearDown( ) override;
- void DAVTypesCheckInit( webdav_ucp::DAVOptions aDavType );
+ void DAVTypesCheckInit( webdav_ucp::DAVOptions& aDavType );
void DAVTypesTest();
void DAVOptsCacheTests();
@@ -51,7 +51,7 @@ namespace
{
}
- void webdav_opts_test::DAVTypesCheckInit( webdav_ucp::DAVOptions aDavType )
+ void webdav_opts_test::DAVTypesCheckInit( webdav_ucp::DAVOptions& aDavType )
{
// check if the class is at reset state
// using accessors
@@ -223,7 +223,7 @@ namespace
aHTTPResponseStatusText.clear();
aDavOpt.setHttpResponseStatusText( aHTTPResponseStatusText );
- OUString aURL = "http://a%20fake%20url/to%20test";
+ OUString aURL = "http://my.server.org/a%20fake%20url/to%20test";
aDavOpt.setURL( aURL );
CPPUNIT_ASSERT_EQUAL( false, aDavOpt.isClass1() );
CPPUNIT_ASSERT_EQUAL( false, aDavOpt.isClass2() );
@@ -240,7 +240,7 @@ namespace
aURL.clear();
aDavOpt.setURL( aURL );
- aURL = "http://a%20fake%20url/to%20test/another-url";
+ aURL = "http://my.server.org/a%20fake%20url/to%20test/another-url";
aDavOpt.setRedirectedURL( aURL );
CPPUNIT_ASSERT_EQUAL( false, aDavOpt.isClass1() );
CPPUNIT_ASSERT_EQUAL( false, aDavOpt.isClass2() );
@@ -257,7 +257,7 @@ namespace
//check the init() function
aAllowedMethods = "OPTIONS,GET,HEAD,POST,DELETE,TRACE,PROPFIND,PROPPATCH,COPY,MOVE,PUT,LOCK,UNLOCK";
- aURL = "http://a%20fake%20url/to%20test/another-url";
+ aURL = "http://my.server.org/a%20fake%20url/to%20test/another-url";
aHTTPResponseStatusText = "404 Not Found";
aDavOpt.setClass1();
aDavOpt.setClass2();
@@ -348,8 +348,8 @@ namespace
webdav_ucp::DAVOptions aDavOptCached;
// init the values
OUString aAllowedMethods = "OPTIONS,GET,HEAD,POST,DELETE,TRACE,PROPFIND,PROPPATCH,COPY,MOVE,PUT,LOCK,UNLOCK";
- OUString aURL = "http://a%20fake%20url/to%20test/another-url";
- OUString aRedirectedURL = "http://a%20fake%20url/to%20test/another-url/redirected";
+ OUString aURL = "http://my.server.org/a%20fake%20url/to%20test/another-url";
+ OUString aRedirectedURL = "http://my.server.org/a%20fake%20url/to%20test/another-url/redirected";
aDavOpt.setURL( aURL );
aDavOpt.setRedirectedURL( aRedirectedURL );
aDavOpt.setClass1();