path: root/tools
diff options
authorLuboš Luňák <>2019-10-03 11:54:28 +0200
committerLuboš Luňák <>2019-10-04 08:57:29 +0200
commitdc34ab8105d9a3a0766a1cbd09b2eeb36fa8f2d2 (patch)
treea332d6bfb7c0bd1ee04f63dcc2cdd0271ac57c98 /tools
parentd1a34deaa87225c5fb7972a93534cfd23a3f6439 (diff)
always use gb_LinkTarget__get_cxxflags for cxxobjects
E.g. gb_LinkTarget_add_exception_object adds it explicitly, but gb_LinkTarget_add_cxxobject itself does not, even though other variants (c,objc,objcxx) do it. This means that when compiling tools/qa/cppunit/test_cpuid.cxx it doesn't get the correct -O/-g flags, because uses gb_CppunitTest_add_cxxobjects to add $(INTRINSICS_CXXFLAGS). And that in its own actually should use the add_exception_objects variant, it didn't presumably because that one used to have cxxflags passing broken until I fixed it in 4bbdab901eb3c7d32d28910fb830f4b0422eee91. The usage in even explicitly works around the lack of debug symbols. Change-Id: Idc794e95bb817cd2ba2942b8e1f04f80d6722f97 Reviewed-on: Tested-by: Jenkins Reviewed-by: Luboš Luňák <>
Diffstat (limited to 'tools')
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/ b/tools/
index 515c3fbd1e14..65f6d02fd782 100644
--- a/tools/
+++ b/tools/
@@ -32,8 +32,8 @@ $(eval $(call gb_CppunitTest_add_exception_objects,tools_test, \
tools/qa/cppunit/test_GenericTypeSerializer \
-$(eval $(call gb_CppunitTest_add_cxxobjects,tools_test,\
- tools/qa/cppunit/test_cpuid, $(gb_LinkTarget_EXCEPTIONFLAGS) $(INTRINSICS_CXXFLAGS) \
+$(eval $(call gb_CppunitTest_add_exception_objects,tools_test,\
+ tools/qa/cppunit/test_cpuid, $(INTRINSICS_CXXFLAGS) \
$(eval $(call gb_CppunitTest_use_sdk_api,tools_test))