diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-04-19 11:14:36 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-04-19 12:41:48 +0200 |
| commit | a759623c3f4bc0265b619ef2bcdff72045a1b5b3 (patch) | |
| tree | 42833d8e6e82009fe5bd5ca3cc0e8d06fb109a61 /testtools | |
| parent | 2ee60f02c456f39a80edb2dbfed48c3e0147a7f7 (diff) | |
loplugin:buriedassign in various
Change-Id: Ib79cbc89f2f89ff48ea8b59bd12373a10b9dcd62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92495
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'testtools')
| -rw-r--r-- | testtools/source/bridgetest/bridgetest.cxx | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/testtools/source/bridgetest/bridgetest.cxx b/testtools/source/bridgetest/bridgetest.cxx index 4abda229d830..3594ff37830d 100644 --- a/testtools/source/bridgetest/bridgetest.cxx +++ b/testtools/source/bridgetest/bridgetest.cxx @@ -158,9 +158,12 @@ static bool equals( const TestData & rData1, const TestData & rData2 ) { sal_Int32 nLen; - if ((rData1.Sequence == rData2.Sequence) && - equals( static_cast<const TestElement &>(rData1), static_cast<const TestElement &>(rData2) ) && - (nLen = rData1.Sequence.getLength()) == rData2.Sequence.getLength()) + if (rData1.Sequence != rData2.Sequence) + return false; + if (!equals( static_cast<const TestElement &>(rData1), static_cast<const TestElement &>(rData2) )) + return false; + nLen = rData1.Sequence.getLength(); + if (nLen == rData2.Sequence.getLength()) { // once again by hand sequence == const TestElement * pElements1 = rData1.Sequence.getConstArray(); |