diff options
| author | Noel Grandin <noel@peralex.com> | 2013-10-25 16:43:20 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2013-10-31 08:34:21 +0200 |
| commit | e2451bd729d0f1d795a5b689deba65bc4e9d92c6 (patch) | |
| tree | 4f2356107b0e58db7afda0fc324b9eac49ff68c0 /testtools | |
| parent | 460b52838fdad0352188bdd877b69cbb5f17ca63 (diff) | |
Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
Diffstat (limited to 'testtools')
| -rw-r--r-- | testtools/source/performance/ubtest.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/testtools/source/performance/ubtest.cxx b/testtools/source/performance/ubtest.cxx index 4c0ea18c2444..f08a0f92d909 100644 --- a/testtools/source/performance/ubtest.cxx +++ b/testtools/source/performance/ubtest.cxx @@ -936,7 +936,7 @@ static OUString extractParam( const Sequence< OUString > & rArgs, const OUString const OUString * pArgs = rArgs.getConstArray(); for ( sal_Int32 nPos = rArgs.getLength(); nPos--; ) { - if (pArgs[nPos].indexOf( rParam ) == 0 && + if (pArgs[nPos].startsWith( rParam ) && pArgs[nPos].getLength() > (rParam.getLength()+1)) { return pArgs[nPos].copy( rParam.getLength() +1 ); // XXX=bla |