diff options
| author | Moaz <moaz.eldefrawy@gmail.com> | 2021-02-25 15:52:06 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-03-05 08:36:52 +0100 |
| commit | dbbda04d52e75858840ce9748a19a61a1c565149 (patch) | |
| tree | 66c2d38ff6b0ef77dae47962050e93614b054db1 /test | |
| parent | 5146d482a20494069670496786a1ba3037e979ce (diff) | |
tdf#139734 Remove redundant asserts after functions loadFromDesktop and load
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.
SwModelTestBase::load calls SwModelTestBase::loadURL which calls loadFromDesktop from within.
Change-Id: I30061bbc6e13e05f0cfbf17a7910926070b996f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111547
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/source/sheet/xspreadsheets2.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/test/source/sheet/xspreadsheets2.cxx b/test/source/sheet/xspreadsheets2.cxx index 9c53af7374fb..406d8baf118a 100644 --- a/test/source/sheet/xspreadsheets2.cxx +++ b/test/source/sheet/xspreadsheets2.cxx @@ -323,9 +323,6 @@ uno::Reference< sheet::XSpreadsheetDocument> XSpreadsheets2::getDoc(const OUStri createFileURL(aFileBase, aFileURL); uno::Reference< lang::XComponent > xComp = loadFromDesktop(aFileURL); - - CPPUNIT_ASSERT(xComp.is()); - uno::Reference< sheet::XSpreadsheetDocument > xDoc(xComp, UNO_QUERY_THROW); return xDoc; } |