diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-31 13:20:41 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-01 09:14:25 +0200 |
| commit | 23b08449736ba825a9c582ba18b7a5fdba178e47 (patch) | |
| tree | 8513c824f1964f84f957a41658f6d173a008c469 /test | |
| parent | 8e63d451b2aeb646ece98c4e219f92957f4482bd (diff) | |
loplugin: look for CPPUNIT_ASSERT_EQUALS with params swapped
idea originally from either tml or moggi, can't remember which
Change-Id: Id78d75035036d3aa1666e33469c6eeb38f9e624d
Reviewed-on: https://gerrit.libreoffice.org/55126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'test')
| -rw-r--r-- | test/source/bootstrapfixture.cxx | 2 | ||||
| -rw-r--r-- | test/source/sheet/xviewpane.cxx | 10 |
2 files changed, 6 insertions, 6 deletions
diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx index 0808a6d4f9e7..184f4ad34c52 100644 --- a/test/source/bootstrapfixture.cxx +++ b/test/source/bootstrapfixture.cxx @@ -122,7 +122,7 @@ OString loadFile(const OUString& rURL) { osl::File aFile(rURL); osl::FileBase::RC eStatus = aFile.open(osl_File_OpenFlag_Read); - CPPUNIT_ASSERT_EQUAL(eStatus, osl::FileBase::E_None); + CPPUNIT_ASSERT_EQUAL(osl::FileBase::E_None, eStatus); sal_uInt64 nSize; aFile.getSize(nSize); std::unique_ptr<char[]> aBytes(new char[nSize]); diff --git a/test/source/sheet/xviewpane.cxx b/test/source/sheet/xviewpane.cxx index ef3a317c1b69..5ea508bf82bf 100644 --- a/test/source/sheet/xviewpane.cxx +++ b/test/source/sheet/xviewpane.cxx @@ -36,16 +36,16 @@ void XViewPane::testFirstVisibleRow() void XViewPane::testVisibleRange() { - sal_Int32 nCol = 5; - sal_Int32 nRow = 3; + constexpr sal_Int32 nCol = 5; + constexpr sal_Int32 nRow = 3; uno::Reference < sheet::XViewPane > xViewPane(init(),UNO_QUERY_THROW); xViewPane->setFirstVisibleColumn(nCol); xViewPane->setFirstVisibleRow(nRow); table::CellRangeAddress aCellRangeAddress = xViewPane->getVisibleRange(); - CPPUNIT_ASSERT_EQUAL(aCellRangeAddress.Sheet, short(0)); - CPPUNIT_ASSERT_EQUAL(aCellRangeAddress.StartRow, nRow); - CPPUNIT_ASSERT_EQUAL(aCellRangeAddress.StartColumn, nCol); + CPPUNIT_ASSERT_EQUAL(short(0), aCellRangeAddress.Sheet); + CPPUNIT_ASSERT_EQUAL(nRow, aCellRangeAddress.StartRow); + CPPUNIT_ASSERT_EQUAL(nCol, aCellRangeAddress.StartColumn); } } |