summaryrefslogtreecommitdiff
path: root/sysui/source/win32/QuickStart
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2021-12-07 14:37:56 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2021-12-07 17:46:23 +0100
commit5de20e45e48f7654d288f26f768fabddad133bfd (patch)
treecce410ce740ae0ca760855a2ddc2ca09d623e633 /sysui/source/win32/QuickStart
parent7e8e57a456f2b946631eecefd163cb4ff3a3d603 (diff)
improve loplugin:cow_wrapperHEADmaster
to find my previous attempt at this, which only obscured the problem <noelgrandin> I'm such an idiot <noelgrandin> I changed a whole bunch of code to avoid calling const methods on a non-const object <noelgrandin> from p->foo() to std::as_const(*p).foo() <noelgrandin> can you spot the mistake? <bubli> Is this a job interview question? :D <vmiklos> noelgrandin: you did the opposite, now you always call const member functions, while you wanted to always call non-const member functions? <noelgrandin> more like a "why didn't the smart people on this channel tell me I was an idiot" :-) <noelgrandin> in this case, we have o3tl::cow_wrapper, which overrides operator* and operator-> <vmiklos> ah, and by the time you would add/remove the const, cow_wrapper already did the expensive task of copying based on const/non-const <noelgrandin> exactly <thorsten> heh Change-Id: I5366e6a87c414b862668b61e6adfbccfdd9d3b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sysui/source/win32/QuickStart')
0 files changed, 0 insertions, 0 deletions