summaryrefslogtreecommitdiff
path: root/swext
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2014-11-18 10:01:21 +0200
committerNoel Grandin <noel@peralex.com>2014-11-18 12:44:28 +0200
commit0063cf285696951e336b9cec1da8881997b286ce (patch)
treebe70dfd8127c35f9e4a6d18d4db459a587813bf4 /swext
parent250391009aec9930abcc57930ddd4b6f56f4df9c (diff)
java: make fields final where possible
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
Diffstat (limited to 'swext')
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/Settings.java6
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java6
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java6
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java4
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java2
-rw-r--r--swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java2
6 files changed, 13 insertions, 13 deletions
diff --git a/swext/mediawiki/src/com/sun/star/wiki/Settings.java b/swext/mediawiki/src/com/sun/star/wiki/Settings.java
index 74d60180ef28..9580f9ea4570 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/Settings.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/Settings.java
@@ -40,10 +40,10 @@ public class Settings
private static Settings m_instance;
- private XComponentContext m_xContext;
+ private final XComponentContext m_xContext;
private int lastUsedWikiServer = 0;
- private List<Map<String, String>> m_WikiConnections = new ArrayList<Map<String, String>>();
- private List<Map<String, Object>> m_aWikiDocs = new ArrayList<Map<String, Object>>();
+ private final List<Map<String, String>> m_WikiConnections = new ArrayList<Map<String, String>>();
+ private final List<Map<String, Object>> m_aWikiDocs = new ArrayList<Map<String, Object>>();
private Settings( XComponentContext ctx )
{
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java b/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java
index 6b87778808eb..e16db7156831 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiArticle.java
@@ -33,7 +33,7 @@ import com.sun.star.uno.XComponentContext;
public class WikiArticle
{
- private XComponentContext m_xContext;
+ private final XComponentContext m_xContext;
private String m_sEditTime = "";
private String m_sEditToken = "";
@@ -44,9 +44,9 @@ public class WikiArticle
private String m_sWikiUser;
private String m_sWikiPass;
- private String m_sTitle = "";
+ private final String m_sTitle;
- private URI m_aMainURI;
+ private final URI m_aMainURI;
private HostConfiguration m_aHostConfig;
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
index 2e262fb37356..aef6cb6a29b6 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java
@@ -37,9 +37,9 @@ public class WikiEditSettingDialog extends WikiDialog
private static final String sOKMethod = "OK";
- private String[] Methods = {sOKMethod };
- private Map<String,String> setting;
- private boolean addMode;
+ private final String[] Methods = {sOKMethod };
+ private final Map<String,String> setting;
+ private final boolean addMode;
private boolean m_bAllowURLChange = true;
public WikiEditSettingDialog( XComponentContext xContext, String DialogURL )
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
index 15ece8c515df..3ad6b5c410b9 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiEditorImpl.java
@@ -57,10 +57,10 @@ public final class WikiEditorImpl extends WeakBase
private static final String protocolName = "vnd.com.sun.star.wiki:";
private final XComponentContext m_xContext;
- private Map<String, com.sun.star.frame.XStatusListener> m_statusListeners = new HashMap<String, com.sun.star.frame.XStatusListener>();
+ private final Map<String, com.sun.star.frame.XStatusListener> m_statusListeners = new HashMap<String, com.sun.star.frame.XStatusListener>();
private XFrame m_xFrame;
private XModel m_xModel;
- private Settings m_aSettings;
+ private final Settings m_aSettings;
private String m_aFilterName;
public WikiEditorImpl( XComponentContext xContext )
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java b/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java
index 9c7ff7939b3a..c3a1f462a89f 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java
@@ -49,7 +49,7 @@ public final class WikiOptionsEventHandlerImpl extends WeakBase
private static final String sOk = "ok";
private static final String sBack = "back";
- private XComponentContext m_xContext;
+ private final XComponentContext m_xContext;
private XDialog m_xDialog;
private XControlContainer m_xControlContainer;
diff --git a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
index 22d8e3d0a439..43fba5c24f84 100644
--- a/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
+++ b/swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java
@@ -34,7 +34,7 @@ public class WikiPropDialog extends WikiDialog{
private static final String sArticleTextMethod = "ArticleTextChange";
private static final String sAddWikiMethod = "AddWiki";
- private String[] m_pMethods = {sSendMethod, sWikiListMethod, sArticleTextMethod, sAddWikiMethod};
+ private final String[] m_pMethods = {sSendMethod, sWikiListMethod, sArticleTextMethod, sAddWikiMethod};
private String m_sWikiTitle = "";
private String m_sWikiEngineURL = "";