diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2021-04-01 16:54:44 +0300 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2021-04-06 16:46:54 +0200 |
| commit | e2fa68f26318da6c7027b71b7f7f79a0c55b7fde (patch) | |
| tree | 37cbfd7abead12d7525e760e0dd7d602372aa542 /sw | |
| parent | fe98f0831ed86bd4a4a179d59fbf0dc094727110 (diff) | |
Exclude tests based on device color depth, not RDP
After 5c9ba1f47d00ed10960b59928befd68f6c020b15, the failures on Jenkins
(see 21191d0d8953a3ca6eac6022c0a14a87fe9c5e2a) made it apparent that
(at least some of) Jenkins builds also run in RDP sessions. Since the
tests excluded in commit 9c6142ec26a0ba61b1cf58d1e6bf0b5376394bcd never
failed in Jenkins builds before, it is wrong to exclude all those tests
in all RDP sessions: our CI would not test those on Windows.
In the meanwhile, I discovered that the system that failed the tests
actually had 16-bit color depth, despite RDP being configured to use
32-bit colors; that was the reason why the colors were modified on
roundtrip. So it is better to test the actual problem to exclude tests.
This reimplements the check that was introduced in commit
9c6142ec26a0ba61b1cf58d1e6bf0b5376394bcd to test default virtual device
color depth.
Change-Id: I329a3e2d8eca21732c77dcacf15394d1246b2e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113466
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 7f2c6fff796f86d685aa20018ae72375011b1367)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113639
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/qa/extras/uiwriter/uiwriter3.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx b/sw/qa/extras/uiwriter/uiwriter3.cxx index f0444d3f3c7a..eedba24768a7 100644 --- a/sw/qa/extras/uiwriter/uiwriter3.cxx +++ b/sw/qa/extras/uiwriter/uiwriter3.cxx @@ -2099,7 +2099,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf135661) CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf133477) { - if (isWindowsRDP()) + if (getDefaultDeviceBitCount() < 24) return; load(DATA_DIRECTORY, "tdf133477.fodt"); SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument*>(mxComponent.get()); |