path: root/sw/source
diff options
authorStephan Bergmann <>2021-06-09 09:33:25 +0200
committerStephan Bergmann <>2021-06-09 10:48:11 +0200
commit07a09195adc65722207390e355a202100bc608ff (patch)
tree7c4aa8d2b76d519b5019df76874c700e08bf305e /sw/source
parent92556e330ede97e11ae2cbc487bb298e6bbcb6bf (diff)
external/pdfium: Latest MSVC now needs the GCC workaround, too
...or else a build with MS VS 2019 16.10.0 and --with-latest-c++ would cause a stack overflow during CppunitTest_xmlsecurity_pdfsigning in the same way as described at 6391e3c4dcd4d61c2f95f996e797e49b5586dbd1 "external/pdfium: Work around GCC C++20 recursive comparison issue". Interestingly, builds with recent Clang (on various platforms) and --with-latest-c++ do not run into that stack overflow issue, so it appears that Clang implements subtly different rules for C++20 and beyond here than do GCC and MSVC. (The GCC issue <> "c++20 rewritten operator== recursive call mixing friend and external operators for template class" mentioned in external/pdfium/ may not be the most accurate description of the precise issue at hand here, but lets keep it at that for now. Its comments do mention "that some people are going to try and change the rules to avoid breaking code like this.") But regardless of what the exact rules are for C++20 and beyond, these problematic overloads are only needed for C++17 and earlier anyway, as C++20 can cover them with automatic rewrites of other operators. So lets generally disable them for C++20 and beyond. Change-Id: I99033d6f09f069f00a6916ef40fd03dd4962a5c4 Reviewed-on: Tested-by: Jenkins Reviewed-by: Stephan Bergmann <>
Diffstat (limited to 'sw/source')
0 files changed, 0 insertions, 0 deletions