diff options
| author | Noel Grandin <noel@peralex.com> | 2016-04-12 16:39:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-18 07:37:31 +0000 |
| commit | 789055bc2acb4c71483fd60ea258d158bd5aec10 (patch) | |
| tree | 7849de841a71f667a30b2a971ad0c3d406110396 /sw/source/uibase/dbui | |
| parent | 150ac9cf05ed9da6a2af5bc3f820280fd853e519 (diff) | |
clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sw/source/uibase/dbui')
| -rw-r--r-- | sw/source/uibase/dbui/dbmgr.cxx | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx index 92c6112919cc..8b9d6d5341fa 100644 --- a/sw/source/uibase/dbui/dbmgr.cxx +++ b/sw/source/uibase/dbui/dbmgr.cxx @@ -717,9 +717,8 @@ bool SwDBManager::GetTableNames(ListBox* pListBox, const OUString& rDBName) xConnection = pParam->xConnection; else { - OUString sDBName(rDBName); - if ( !sDBName.isEmpty() ) - xConnection = RegisterConnection( sDBName ); + if ( !rDBName.isEmpty() ) + xConnection = RegisterConnection( rDBName ); } if(xConnection.is()) { @@ -768,8 +767,7 @@ void SwDBManager::GetColumnNames(ListBox* pListBox, xConnection = pParam->xConnection; else { - OUString sDBName(rDBName); - xConnection = RegisterConnection( sDBName ); + xConnection = RegisterConnection( rDBName ); } GetColumnNames(pListBox, xConnection, rTableName); } @@ -1666,8 +1664,7 @@ sal_uLong SwDBManager::GetColumnFormat( const OUString& rDBName, } else { - OUString sDBName(rDBName); - xConnection = RegisterConnection( sDBName ); + xConnection = RegisterConnection( rDBName ); bDisposeConnection = true; } if(bUseMergeData) @@ -1812,8 +1809,7 @@ sal_Int32 SwDBManager::GetColumnType( const OUString& rDBName, } else { - OUString sDBName(rDBName); - xConnection = RegisterConnection( sDBName ); + xConnection = RegisterConnection( rDBName ); } if( !xColsSupp.is() ) { |