summaryrefslogtreecommitdiff
path: root/sw/source/filter/html/htmlreqifreader.cxx
diff options
context:
space:
mode:
authorMichael Stahl <Michael.Stahl@cib.de>2020-11-16 13:08:48 +0100
committerMiklos Vajna <vmiklos@collabora.com>2021-10-08 15:03:02 +0200
commita543433c730eac8f91b49c6a7993ae26e67d309b (patch)
treeda38c47b7a93c7a676f9ecabfc635bb63b2f4d24 /sw/source/filter/html/htmlreqifreader.cxx
parentf6405603547435442ad4b11a37c8cdc68b063f3e (diff)
(related tdf#134298) sw: layout: avoid infinite loop in InternalAction()
The condition IsInterrupt() && pPage && (m_nCheckPageNum != USHRT_MAX) isn't handled properly and the while loop will never terminate with the fix for tdf#134298 in several UITest_writer_tests*. If m_nCheckPageNum is set, then it must result in a call to CheckPageDescs() here; it's a member of SwLayAction so won't survive until the next idle layout invocation. There is a funny history of these loop conditions with commit 9eff9e699e17cc5a8a25895bd28dc8e4ceb8071e and cee296066ab780217395201ab84c2150c8840d25 so we can only hope this time we got it right... (cherry picked from commit 094ee3955ee81e1bc631d50cc216cbb17a777839) Change-Id: I91b63540bf4280296d747cb8e841594f8dd3b140
Diffstat (limited to 'sw/source/filter/html/htmlreqifreader.cxx')
0 files changed, 0 insertions, 0 deletions