remove unnecessary "if (!empty()" checks before loops

found with
   git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'

Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 16 insertions, 19 deletions

diff --git a/sw/source/core/unocore/unoportenum.cxx b/sw/source/core/unocore/unoportenum.cxx
index 0776b3325261..1ba5b3f760a5 100644
--- a/sw/source/core/unocore/unoportenum.cxx
+++ b/sw/source/core/unocore/unoportenum.cxx
@@ -1176,29 +1176,26 @@ static void lcl_ExportAnnotationStarts(
     SwAnnotationStartPortion_ImplList& rAnnotationStartArr,
     const sal_Int32 nIndex)
 {
-    if ( !rAnnotationStartArr.empty() )
+    for ( SwAnnotationStartPortion_ImplList::iterator aIter = rAnnotationStartArr.begin(), aEnd = rAnnotationStartArr.end();
+          aIter != aEnd; )
     {
-        for ( SwAnnotationStartPortion_ImplList::iterator aIter = rAnnotationStartArr.begin(), aEnd = rAnnotationStartArr.end();
-              aIter != aEnd; )
+        SwAnnotationStartPortion_ImplSharedPtr pPtr = (*aIter);
+        if ( nIndex > pPtr->getIndex() )
         {
-            SwAnnotationStartPortion_ImplSharedPtr pPtr = (*aIter);
-            if ( nIndex > pPtr->getIndex() )
-            {
-                aIter = rAnnotationStartArr.erase(aIter);
-                continue;
-            }
-            if ( pPtr->getIndex() > nIndex )
-            {
-                break;
-            }
-
-            SwXTextPortion* pPortion =
-                new SwXTextPortion( pUnoCursor, xParent, PORTION_ANNOTATION );
-            pPortion->SetTextField( pPtr->mxAnnotationField );
-            rPortions.emplace_back(pPortion);
-
             aIter = rAnnotationStartArr.erase(aIter);
+            continue;
         }
+        if ( pPtr->getIndex() > nIndex )
+        {
+            break;
+        }
+
+        SwXTextPortion* pPortion =
+            new SwXTextPortion( pUnoCursor, xParent, PORTION_ANNOTATION );
+         pPortion->SetTextField( pPtr->mxAnnotationField );
+        rPortions.emplace_back(pPortion);
+
+        aIter = rAnnotationStartArr.erase(aIter);
     }
 }