diff options
| author | Noel Grandin <noel@peralex.com> | 2014-06-18 12:14:29 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-06-24 11:34:21 +0200 |
| commit | e2080e70fe8b085f18e868e46340454720fa94ca (patch) | |
| tree | 4038d1d57b41b68a47d5ebbbe6ad390648ec6303 /sw/source/core/txtnode/txtedt.cxx | |
| parent | f910280b8704ed9c289150a4ca3c8d60e15d0d97 (diff) | |
new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
Diffstat (limited to 'sw/source/core/txtnode/txtedt.cxx')
| -rw-r--r-- | sw/source/core/txtnode/txtedt.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sw/source/core/txtnode/txtedt.cxx b/sw/source/core/txtnode/txtedt.cxx index 6c2adee3c350..af8e9f2a10e3 100644 --- a/sw/source/core/txtnode/txtedt.cxx +++ b/sw/source/core/txtnode/txtedt.cxx @@ -392,9 +392,9 @@ void SwTxtNode::RstTxtAttr( } if ( pTxtInputFld != NULL ) { - if ( nStt > *(pTxtInputFld->GetStart()) ) + if ( nStt > pTxtInputFld->GetStart() ) { - nStt = *(pTxtInputFld->GetStart()); + nStt = pTxtInputFld->GetStart(); } if ( nEnd < *(pTxtInputFld->End()) ) { @@ -420,7 +420,7 @@ void SwTxtNode::RstTxtAttr( sal_Int32 nAttrStart; SwTxtAttr *pHt = NULL; while ( (i < m_pSwpHints->Count()) - && ( ( ( nAttrStart = *(*m_pSwpHints)[i]->GetStart()) < nEnd ) + && ( ( ( nAttrStart = (*m_pSwpHints)[i]->GetStart()) < nEnd ) || nLen==0 ) ) { pHt = m_pSwpHints->GetTextHint(i); @@ -531,7 +531,7 @@ void SwTxtNode::RstTxtAttr( { m_pSwpHints->NoteInHistory( pHt ); // UGLY: this may temporarily destroy the sorting! - *pHt->GetStart() = nEnd; + pHt->GetStart() = nEnd; m_pSwpHints->NoteInHistory( pHt, true ); if ( pStyleHandle.get() && nAttrStart < nEnd ) |