summaryrefslogtreecommitdiff
path: root/sw/source/core/ole/ndole.cxx
diff options
context:
space:
mode:
authorTushar Bende <tushar.bende@synerzip.com>2013-12-09 19:13:36 +0530
committerMiklos Vajna <vmiklos@collabora.co.uk>2013-12-16 13:08:26 +0100
commitbee397a1e35fbc2717c56a8bd4a631ccfc185b6b (patch)
tree70b699ed0c49002c79950734f6fa1737da6f3a6d /sw/source/core/ole/ndole.cxx
parent8c5b4bb03cdf3fd5e794cfd8de68b00eb5de48fb (diff)
fdo#68211: Fix for "General input/output error" while opening file
Description: Docx containing floating table with formula was giving "General input/output error" while opening in LibreOffice. Reason being within xLoader->filter() it was calling EmbeddedObjectContainer::RemoveEmbeddedObject() with bClose value as sal_True(default value in function declaration) and hence it was removing embedded object from container and also it was closing it.Fix includes passing this bClose value as sal_false (which means remove object from container but don't close it.) verified code changes for various floating table docx and normal docx containing tables and formulas. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/7009 Change-Id: I9c2d3f8c4099f9f753b2a1b027f9072cd4effeb5
Diffstat (limited to 'sw/source/core/ole/ndole.cxx')
-rw-r--r--sw/source/core/ole/ndole.cxx5
1 files changed, 3 insertions, 2 deletions
diff --git a/sw/source/core/ole/ndole.cxx b/sw/source/core/ole/ndole.cxx
index e3793afb9845..64739126a110 100644
--- a/sw/source/core/ole/ndole.cxx
+++ b/sw/source/core/ole/ndole.cxx
@@ -715,10 +715,11 @@ SwOLEObj::~SwOLEObj()
// successful closing of the object will automatically clear the reference then
xOLERef.Lock(sal_False);
- // Always remove object from conteiner it is connected to
+ // Always remove object from container it is connected to
try
{
- pCnt->RemoveEmbeddedObject( aName );
+ // remove object from container but don't close it
+ pCnt->RemoveEmbeddedObject( aName, sal_False);
}
catch ( uno::Exception& )
{