summaryrefslogtreecommitdiff
path: root/sw/qa/extras/ww8export/ww8export3.cxx
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2019-10-28 21:52:18 +0100
committerMiklos Vajna <vmiklos@collabora.com>2019-10-29 08:41:47 +0100
commit5d1709a7c4184eb31cfc4c2d3acadff3a4a68189 (patch)
tree398ec3ac3bb7aa8b006fb88e3999b24f3bd79ef5 /sw/qa/extras/ww8export/ww8export3.cxx
parent4e7d4eac01f180b19aea98e1f40b4cffe3fd2aac (diff)
tdf#104017 DOC export: be less aggressive with merging page styles
Regression from commit 7146d8bcd96f844dc0239a5b29a6b36c3cb5a2cc (MSWordExportBase::OutputSectionBreaks: avoid fake section breaks, 2014-07-28), the problem was that we merged two separate page styles just because they were similar. This resulted in merging two independent tables into a single one. Fix the problem by merging the first and follow page style only in case the first page style is RES_POOLPAGE_FIRST, this resolves the current problem and keeps the original problem fixed, too. (Long-term, a better fix would be to not split the page styles in writerfilter/, similar to how the DOC import doesn't do that anymore: and then the merging can be avoided unconditionally.) Change-Id: I357f1337cb0abc7fa1d88aa44ff87b4b464af81c Reviewed-on: https://gerrit.libreoffice.org/81630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'sw/qa/extras/ww8export/ww8export3.cxx')
-rw-r--r--sw/qa/extras/ww8export/ww8export3.cxx9
1 files changed, 9 insertions, 0 deletions
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx b/sw/qa/extras/ww8export/ww8export3.cxx
index 2e92346ea04b..cb4caa351b98 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -361,6 +361,15 @@ DECLARE_WW8EXPORT_TEST(testPresetDash, "tdf127166_prstDash_Word97.doc")
}
}
+DECLARE_WW8EXPORT_TEST(testTdf104017, "tdf104017.doc")
+{
+ // Without the accompanying fix in place, this test would have failed with:
+ // - Expected: 2
+ // - Actual : 1
+ // i.e. the tables on the two pages were merged together to a single one on export.
+ CPPUNIT_ASSERT_EQUAL(2, getPages());
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */