diff options
| author | Moaz <moaz.eldefrawy@gmail.com> | 2021-02-25 15:52:06 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-03-05 08:36:52 +0100 |
| commit | dbbda04d52e75858840ce9748a19a61a1c565149 (patch) | |
| tree | 66c2d38ff6b0ef77dae47962050e93614b054db1 /sw/qa/extras/uiwriter/uiwriter.cxx | |
| parent | 5146d482a20494069670496786a1ba3037e979ce (diff) | |
tdf#139734 Remove redundant asserts after functions loadFromDesktop and load
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.
SwModelTestBase::load calls SwModelTestBase::loadURL which calls loadFromDesktop from within.
Change-Id: I30061bbc6e13e05f0cfbf17a7910926070b996f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111547
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sw/qa/extras/uiwriter/uiwriter.cxx')
| -rw-r--r-- | sw/qa/extras/uiwriter/uiwriter.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index cfb22cd86ca2..fa5209497862 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -4455,7 +4455,6 @@ void SwUiWriterTest::testEmbeddedDataSource() // Load: should have a component and a data source, too. // Path with "#" must not cause issues load(OUString(DATA_DIRECTORY + OUStringLiteral(u"hash%23path/")), "embedded-data-source.odt"); - CPPUNIT_ASSERT(mxComponent.is()); CPPUNIT_ASSERT(xDatabaseContext->hasByName("calc-data-source")); // Data source has a table named Sheet1. |