diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-14 10:41:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-14 11:37:35 +0200 |
commit | 8303e7ed668fbcbd0ba75bd9dd259f03073ffd46 (patch) | |
tree | bfcbb0f58c0fd8cbd5c03d93fc5b1d4ab3ef817b /svx | |
parent | a64692944a0a22feeef4a943d45137b25494cf64 (diff) |
loplugin:unusedfields improvements
tighten up the only calling write-only methods part of the analysis
Change-Id: I5bc6fdf0ce51940653317e8a48c5241705c90d4c
Reviewed-on: https://gerrit.libreoffice.org/74022
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
-rw-r--r-- | svx/source/dialog/dlgctl3d.cxx | 15 | ||||
-rw-r--r-- | svx/source/dialog/rlrcitem.cxx | 2 | ||||
-rw-r--r-- | svx/source/dialog/svxruler.cxx | 6 |
3 files changed, 2 insertions, 21 deletions
diff --git a/svx/source/dialog/dlgctl3d.cxx b/svx/source/dialog/dlgctl3d.cxx index 56c3f424a34c..c61a9472f2e9 100644 --- a/svx/source/dialog/dlgctl3d.cxx +++ b/svx/source/dialog/dlgctl3d.cxx @@ -1932,11 +1932,6 @@ void SvxLightCtl3D::move( double fDeltaHor, double fDeltaVer ) maLightControl->SetPosition(fHor, fVer); maHorScroller->SetThumbPos( sal_Int32(fHor * 100.0) ); maVerScroller->SetThumbPos( 18000 - sal_Int32((fVer + 90.0) * 100.0) ); - - if(maUserInteractiveChangeCallback.IsSet()) - { - maUserInteractiveChangeCallback.Call(this); - } } void SvxLightCtl3D::KeyInput( const KeyEvent& rKEvt ) @@ -2083,11 +2078,6 @@ IMPL_LINK_NOARG(SvxLightCtl3D, ScrollBarMove, ScrollBar*, void) maLightControl->SetPosition( static_cast<double>(nHor) / 100.0, static_cast<double>((18000 - nVer) - 9000) / 100.0); - - if(maUserInteractiveChangeCallback.IsSet()) - { - maUserInteractiveChangeCallback.Call(this); - } } IMPL_LINK_NOARG(SvxLightCtl3D, ButtonPress, Button*, void) @@ -2109,11 +2099,6 @@ IMPL_LINK_NOARG(SvxLightCtl3D, InternalInteractiveChange, Svx3DLightControl*, vo maLightControl->GetPosition(fHor, fVer); maHorScroller->SetThumbPos( sal_Int32(fHor * 100.0) ); maVerScroller->SetThumbPos( 18000 - sal_Int32((fVer + 90.0) * 100.0) ); - - if(maUserInteractiveChangeCallback.IsSet()) - { - maUserInteractiveChangeCallback.Call(this); - } } IMPL_LINK_NOARG(SvxLightCtl3D, InternalSelectionChange, Svx3DLightControl*, void) diff --git a/svx/source/dialog/rlrcitem.cxx b/svx/source/dialog/rlrcitem.cxx index 49284af8a9fa..ae962efdf4bc 100644 --- a/svx/source/dialog/rlrcitem.cxx +++ b/svx/source/dialog/rlrcitem.cxx @@ -132,7 +132,7 @@ void SvxRulerItem::StateChanged( sal_uInt16 nSID, SfxItemState eState, { const SvxLRSpaceItem *pItem = dynamic_cast<const SvxLRSpaceItem*>( pState ); SAL_WARN_IF(pState != nullptr && pItem == nullptr, "svx.dialog", "SvxLRSpaceItem expected"); - rRuler.UpdateParaBorder(pItem); + rRuler.UpdateParaBorder(); } break; case SID_RULER_TEXT_RIGHT_TO_LEFT : diff --git a/svx/source/dialog/svxruler.cxx b/svx/source/dialog/svxruler.cxx index 8b0123c039cf..29cd1ee88901 100644 --- a/svx/source/dialog/svxruler.cxx +++ b/svx/source/dialog/svxruler.cxx @@ -947,15 +947,11 @@ void SvxRuler::UpdatePara(const SvxLRSpaceItem *pItem) // new value of paragraph } } -void SvxRuler::UpdateParaBorder(const SvxLRSpaceItem * pItem ) +void SvxRuler::UpdateParaBorder() { /* Border distance */ if(bActive) { - if(pItem) - mxParaBorderItem.reset(new SvxLRSpaceItem(*pItem)); - else - mxParaBorderItem.reset(); StartListening_Impl(); } } |