diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-11 13:51:50 +0200 |
---|---|---|
committer | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2016-07-20 01:26:02 -0400 |
commit | d77b00ca4d6869ae233e9de2babc67138a2168fb (patch) | |
tree | 4f862197ff166c5dd5a25e6aee2630122e1d77a3 /svx | |
parent | d4a40252db48f58e7ff94c59932f1c015e183170 (diff) |
clang-tidy performance-unnecessary-value-param in svx
(cherry picked from commit e9cded40c8727cec7d0d29219c14ef0d0eef5195)
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
Diffstat (limited to 'svx')
-rw-r--r-- | svx/source/dialog/rubydialog.cxx | 4 | ||||
-rw-r--r-- | svx/source/fmcomp/gridcell.cxx | 2 | ||||
-rw-r--r-- | svx/source/form/fmpgeimp.cxx | 2 | ||||
-rw-r--r-- | svx/source/form/fmvwimp.cxx | 2 | ||||
-rw-r--r-- | svx/source/inc/fmpgeimp.hxx | 2 | ||||
-rw-r--r-- | svx/source/inc/gridcell.hxx | 2 | ||||
-rw-r--r-- | svx/source/items/SmartTagItem.cxx | 6 | ||||
-rw-r--r-- | svx/source/sidebar/line/LineWidthValueSet.cxx | 2 | ||||
-rw-r--r-- | svx/source/sidebar/line/LineWidthValueSet.hxx | 2 | ||||
-rw-r--r-- | svx/source/svdraw/svdmodel.cxx | 4 | ||||
-rw-r--r-- | svx/source/tbxctrls/PaletteManager.cxx | 2 | ||||
-rw-r--r-- | svx/source/tbxctrls/tbcontrl.cxx | 4 | ||||
-rw-r--r-- | svx/source/unodraw/unopage.cxx | 2 | ||||
-rw-r--r-- | svx/source/unodraw/unoshape.cxx | 4 | ||||
-rw-r--r-- | svx/source/xml/xmlxtexp.cxx | 2 | ||||
-rw-r--r-- | svx/source/xml/xmlxtimp.cxx | 2 |
16 files changed, 22 insertions, 22 deletions
diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx index 6e308197ffa7..223727c85059 100644 --- a/svx/source/dialog/rubydialog.cxx +++ b/svx/source/dialog/rubydialog.cxx @@ -95,7 +95,7 @@ public: SvxRubyData_Impl(); virtual ~SvxRubyData_Impl(); - void SetController(Reference<XController> xCtrl); + void SetController(const Reference<XController>& xCtrl); Reference<XModel> GetModel() { if (!xController.is()) @@ -143,7 +143,7 @@ SvxRubyData_Impl::~SvxRubyData_Impl() { } -void SvxRubyData_Impl::SetController(Reference<XController> xCtrl) +void SvxRubyData_Impl::SetController(const Reference<XController>& xCtrl) { if (xCtrl.get() != xController.get()) { diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx index 52679d3085ab..28115bc369f0 100644 --- a/svx/source/fmcomp/gridcell.cxx +++ b/svx/source/fmcomp/gridcell.cxx @@ -298,7 +298,7 @@ DbGridColumn::~DbGridColumn() } -void DbGridColumn::setModel(css::uno::Reference< css::beans::XPropertySet > _xModel) +void DbGridColumn::setModel(const css::uno::Reference< css::beans::XPropertySet >& _xModel) { if ( m_pCell ) impl_toggleScriptManager_nothrow( false ); diff --git a/svx/source/form/fmpgeimp.cxx b/svx/source/form/fmpgeimp.cxx index a403d0834a4c..a60b9b9f0f60 100644 --- a/svx/source/form/fmpgeimp.cxx +++ b/svx/source/form/fmpgeimp.cxx @@ -356,7 +356,7 @@ bool FmFormPageImpl::validateCurForm() } -void FmFormPageImpl::setCurForm(Reference< css::form::XForm > xForm) +void FmFormPageImpl::setCurForm(const Reference< css::form::XForm >& xForm) { xCurrentForm = xForm; } diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx index 9c0cc8b60adb..b49d64418dfa 100644 --- a/svx/source/form/fmvwimp.cxx +++ b/svx/source/form/fmvwimp.cxx @@ -680,7 +680,7 @@ namespace public: - explicit find_active_databaseform( const Reference< XFormController > _xActiveController ) + explicit find_active_databaseform( const Reference< XFormController >& _xActiveController ) : xActiveController(_xActiveController ) {} diff --git a/svx/source/inc/fmpgeimp.hxx b/svx/source/inc/fmpgeimp.hxx index 3b9263db24e8..0977cf7a5102 100644 --- a/svx/source/inc/fmpgeimp.hxx +++ b/svx/source/inc/fmpgeimp.hxx @@ -66,7 +66,7 @@ public: void initFrom( FmFormPageImpl& i_foreignImpl ); // nur wichtig fuer den DesignMode - void setCurForm(css::uno::Reference< css::form::XForm> xForm); + void setCurForm(const css::uno::Reference< css::form::XForm>& xForm); css::uno::Reference< css::form::XForm> getDefaultForm(); /** finds a place in the form component hierarchy where to insert the given component diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx index 3080ab730b1d..c1a510ad6429 100644 --- a/svx/source/inc/gridcell.hxx +++ b/svx/source/inc/gridcell.hxx @@ -119,7 +119,7 @@ public: ~DbGridColumn(); const css::uno::Reference< css::beans::XPropertySet >& getModel() const { return m_xModel; } - void setModel(css::uno::Reference< css::beans::XPropertySet > _xModel); + void setModel(const css::uno::Reference< css::beans::XPropertySet >& _xModel); sal_uInt16 GetId() const {return m_nId;} diff --git a/svx/source/items/SmartTagItem.cxx b/svx/source/items/SmartTagItem.cxx index fc13f378425e..312b616bc6e4 100644 --- a/svx/source/items/SmartTagItem.cxx +++ b/svx/source/items/SmartTagItem.cxx @@ -32,9 +32,9 @@ SvxSmartTagItem::SvxSmartTagItem( const sal_uInt16 nId, const css::uno::Sequence < css::uno::Sequence< css::uno::Reference< css::smarttags::XSmartTagAction > > >& rActionComponentsSequence, const css::uno::Sequence < css::uno::Sequence< sal_Int32 > >& rActionIndicesSequence, const css::uno::Sequence< css::uno::Reference< css::container::XStringKeyMap > >& rStringKeyMaps, - const css::uno::Reference<css::text::XTextRange> rRange, - const css::uno::Reference<css::frame::XController> rController, - const css::lang::Locale rLocale, + const css::uno::Reference<css::text::XTextRange>& rRange, + const css::uno::Reference<css::frame::XController>& rController, + const css::lang::Locale& rLocale, const OUString& rApplicationName, const OUString& rRangeText ) : SfxPoolItem( nId ), diff --git a/svx/source/sidebar/line/LineWidthValueSet.cxx b/svx/source/sidebar/line/LineWidthValueSet.cxx index 2d41152032c0..6530b4ea8eb9 100644 --- a/svx/source/sidebar/line/LineWidthValueSet.cxx +++ b/svx/source/sidebar/line/LineWidthValueSet.cxx @@ -70,7 +70,7 @@ void LineWidthValueSet::SetSelItem(sal_uInt16 nSel) } } -void LineWidthValueSet::SetImage(Image img) +void LineWidthValueSet::SetImage(const Image& img) { imgCus = img; } diff --git a/svx/source/sidebar/line/LineWidthValueSet.hxx b/svx/source/sidebar/line/LineWidthValueSet.hxx index b99e0dbbb402..a02d70fe7175 100644 --- a/svx/source/sidebar/line/LineWidthValueSet.hxx +++ b/svx/source/sidebar/line/LineWidthValueSet.hxx @@ -35,7 +35,7 @@ public: void SetUnit(OUString* str); void SetSelItem(sal_uInt16 nSel); sal_uInt16 GetSelItem() { return nSelItem;} - void SetImage(Image img); + void SetImage(const Image& img); void SetCusEnable(bool bEnable); virtual void UserDraw( const UserDrawEvent& rUDEvt ) override; diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx index a50c607f4cc9..5fd292fe131b 100644 --- a/svx/source/svdraw/svdmodel.cxx +++ b/svx/source/svdraw/svdmodel.cxx @@ -1834,7 +1834,7 @@ uno::Reference< uno::XInterface > SdrModel::getUnoModel() return mxUnoModel; } -void SdrModel::setUnoModel( css::uno::Reference< css::uno::XInterface > xModel ) +void SdrModel::setUnoModel( const css::uno::Reference< css::uno::XInterface >& xModel ) { mxUnoModel = xModel; } @@ -1917,7 +1917,7 @@ void SdrModel::MigrateItemSet( const SfxItemSet* pSourceSet, SfxItemSet* pDestSe } -void SdrModel::SetForbiddenCharsTable( rtl::Reference<SvxForbiddenCharactersTable> xForbiddenChars ) +void SdrModel::SetForbiddenCharsTable( const rtl::Reference<SvxForbiddenCharactersTable>& xForbiddenChars ) { if( mpForbiddenCharactersTable ) mpForbiddenCharactersTable->release(); diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx index 430623ebc500..535134f344de 100644 --- a/svx/source/tbxctrls/PaletteManager.cxx +++ b/svx/source/tbxctrls/PaletteManager.cxx @@ -219,7 +219,7 @@ void PaletteManager::SetBtnUpdater(svx::ToolboxButtonColorUpdater* pBtnUpdater) mpBtnUpdater = pBtnUpdater; } -void PaletteManager::SetColorSelectFunction(std::function<void(const OUString&, const Color&)> aColorSelectFunction) +void PaletteManager::SetColorSelectFunction(const std::function<void(const OUString&, const Color&)>& aColorSelectFunction) { maColorSelectFunction = aColorSelectFunction; } diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx index 8ec24213b7e5..394034a23aa4 100644 --- a/svx/source/tbxctrls/tbcontrl.cxx +++ b/svx/source/tbxctrls/tbcontrl.cxx @@ -2012,7 +2012,7 @@ struct SvxStyleToolBoxControl::Impl } - void InitializeStyles(Reference < frame::XModel > xModel) + void InitializeStyles(const Reference < frame::XModel >& xModel) { //now convert the default style names to the localized names try @@ -2611,7 +2611,7 @@ SvxColorToolBoxControl::~SvxColorToolBoxControl() { } -void SvxColorToolBoxControl::setColorSelectFunction(ColorSelectFunction aColorSelectFunction) +void SvxColorToolBoxControl::setColorSelectFunction(const ColorSelectFunction& aColorSelectFunction) { maColorSelectFunction = aColorSelectFunction; mPaletteManager.SetColorSelectFunction(aColorSelectFunction); diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx index 7376b8e8172e..59ed025e2a25 100644 --- a/svx/source/unodraw/unopage.cxx +++ b/svx/source/unodraw/unopage.cxx @@ -910,7 +910,7 @@ uno::Reference< drawing::XDrawPage > GetXDrawPageForSdrPage( SdrPage* pPage ) th } /** returns the SdrObject from the given StarOffice API wrapper */ -SdrPage* GetSdrPageFromXDrawPage( uno::Reference< drawing::XDrawPage > xDrawPage ) throw() +SdrPage* GetSdrPageFromXDrawPage( const uno::Reference< drawing::XDrawPage >& xDrawPage ) throw() { if(xDrawPage.is()) { diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx index 2dff1ef4f7d7..ebc645f96a93 100644 --- a/svx/source/unodraw/unoshape.cxx +++ b/svx/source/unodraw/unoshape.cxx @@ -593,7 +593,7 @@ void SvxShape::ForceMetricTo100th_mm(basegfx::B2DPolyPolygon& rPolyPolygon) cons void SvxItemPropertySet_ObtainSettingsFromPropertySet(const SvxItemPropertySet& rPropSet, - SfxItemSet& rSet, uno::Reference< beans::XPropertySet > xSet, const SfxItemPropertyMap* pMap ) + SfxItemSet& rSet, const uno::Reference< beans::XPropertySet >& xSet, const SfxItemPropertyMap* pMap ) { if(rPropSet.AreThereOwnUsrAnys()) { @@ -4134,7 +4134,7 @@ uno::Reference< drawing::XShape > GetXShapeForSdrObject( SdrObject* pObj ) throw } /** returns the SdrObject from the given StarOffice API wrapper */ -SdrObject* GetSdrObjectFromXShape( uno::Reference< drawing::XShape > xShape ) throw() +SdrObject* GetSdrObjectFromXShape( const uno::Reference< drawing::XShape >& xShape ) throw() { SvxShape* pShape = SvxShape::getImplementation( xShape ); return pShape ? pShape->GetSdrObject() : nullptr; diff --git a/svx/source/xml/xmlxtexp.cxx b/svx/source/xml/xmlxtexp.cxx index 27d2b1a810c7..c6b9f1987846 100644 --- a/svx/source/xml/xmlxtexp.cxx +++ b/svx/source/xml/xmlxtexp.cxx @@ -188,7 +188,7 @@ static void initializeStreamMetadata( const uno::Reference< uno::XInterface > &x static void createStorageStream( uno::Reference < io::XOutputStream > *xOut, SvXMLGraphicHelper **ppGraphicHelper, - uno::Reference < embed::XStorage > xSubStorage ) + const uno::Reference < embed::XStorage >& xSubStorage ) { uno::Reference < io::XStream > xStream; xStream = xSubStorage->openStreamElement( diff --git a/svx/source/xml/xmlxtimp.cxx b/svx/source/xml/xmlxtimp.cxx index 0183888ac50f..09746038966e 100644 --- a/svx/source/xml/xmlxtimp.cxx +++ b/svx/source/xml/xmlxtimp.cxx @@ -348,7 +348,7 @@ SvxXMLXTableImport::~SvxXMLXTableImport() throw () static void openStorageStream( xml::sax::InputSource *pParserInput, SvXMLGraphicHelper **ppGraphicHelper, - uno::Reference < embed::XStorage > xStorage ) + const uno::Reference < embed::XStorage >& xStorage ) { uno::Reference < io::XStream > xIStm; xIStm.set( xStorage->openStreamElement( "Content.xml", embed::ElementModes::READ ), uno::UNO_QUERY_THROW ); |