clang-tidy performance-unnecessary-value-param in svx

Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b

17 files changed, 24 insertions, 24 deletions

diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx
index ae9c7a947e73..6c088737152f 100644
--- a/svx/source/dialog/rubydialog.cxx
+++ b/svx/source/dialog/rubydialog.cxx
@@ -95,7 +95,7 @@ public:
     SvxRubyData_Impl();
     virtual ~SvxRubyData_Impl();
 
-    void SetController(Reference<XController> xCtrl);
+    void SetController(const Reference<XController>& xCtrl);
     Reference<XModel> GetModel()
     {
         if (!xController.is())
@@ -143,7 +143,7 @@ SvxRubyData_Impl::~SvxRubyData_Impl()
 {
 }
 
-void SvxRubyData_Impl::SetController(Reference<XController> xCtrl)
+void SvxRubyData_Impl::SetController(const Reference<XController>& xCtrl)
 {
     if (xCtrl.get() != xController.get())
     {
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 8f9861e6fa2f..d2577e6ad104 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -297,7 +297,7 @@ DbGridColumn::~DbGridColumn()
 }
 
 
-void DbGridColumn::setModel(css::uno::Reference< css::beans::XPropertySet >  _xModel)
+void DbGridColumn::setModel(const css::uno::Reference< css::beans::XPropertySet >&  _xModel)
 {
     if ( m_pCell )
         impl_toggleScriptManager_nothrow( false );
diff --git a/svx/source/form/fmpgeimp.cxx b/svx/source/form/fmpgeimp.cxx
index d775aca5aa2c..895f729e16c1 100644
--- a/svx/source/form/fmpgeimp.cxx
+++ b/svx/source/form/fmpgeimp.cxx
@@ -355,7 +355,7 @@ bool FmFormPageImpl::validateCurForm()
 }
 
 
-void FmFormPageImpl::setCurForm(Reference< css::form::XForm >  xForm)
+void FmFormPageImpl::setCurForm(const Reference< css::form::XForm >&  xForm)
 {
     xCurrentForm = xForm;
 }
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 6fb1a9b21257..8c2daea4784d 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -680,7 +680,7 @@ namespace
 
     public:
 
-        explicit find_active_databaseform( const Reference< XFormController > _xActiveController )
+        explicit find_active_databaseform( const Reference< XFormController >& _xActiveController )
             : xActiveController(_xActiveController )
         {}
 
diff --git a/svx/source/inc/fmpgeimp.hxx b/svx/source/inc/fmpgeimp.hxx
index ae743c05729c..17cf77b9c966 100644
--- a/svx/source/inc/fmpgeimp.hxx
+++ b/svx/source/inc/fmpgeimp.hxx
@@ -65,7 +65,7 @@ public:
     void initFrom( FmFormPageImpl& i_foreignImpl );
 
     //  nur wichtig fuer den DesignMode
-    void setCurForm(css::uno::Reference< css::form::XForm> xForm);
+    void setCurForm(const css::uno::Reference< css::form::XForm>& xForm);
     css::uno::Reference< css::form::XForm> getDefaultForm();
 
     /** finds a place in the form component hierarchy where to insert the given component
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 9b0efa82a2da..786c49027728 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -120,7 +120,7 @@ public:
     ~DbGridColumn();
 
     const css::uno::Reference< css::beans::XPropertySet >& getModel() const { return m_xModel; }
-    void  setModel(css::uno::Reference< css::beans::XPropertySet >  _xModel);
+    void  setModel(const css::uno::Reference< css::beans::XPropertySet >&  _xModel);
 
 
     sal_uInt16  GetId() const {return m_nId;}
diff --git a/svx/source/items/SmartTagItem.cxx b/svx/source/items/SmartTagItem.cxx
index c81eacc88787..e80c6f8c89d3 100644
--- a/svx/source/items/SmartTagItem.cxx
+++ b/svx/source/items/SmartTagItem.cxx
@@ -32,9 +32,9 @@ SvxSmartTagItem::SvxSmartTagItem( const sal_uInt16 nId,
                                   const css::uno::Sequence < css::uno::Sequence< css::uno::Reference< css::smarttags::XSmartTagAction > > >& rActionComponentsSequence,
                                   const css::uno::Sequence < css::uno::Sequence< sal_Int32 > >& rActionIndicesSequence,
                                   const css::uno::Sequence< css::uno::Reference< css::container::XStringKeyMap > >& rStringKeyMaps,
-                                  const css::uno::Reference<css::text::XTextRange> rRange,
-                                  const css::uno::Reference<css::frame::XController> rController,
-                                  const css::lang::Locale rLocale,
+                                  const css::uno::Reference<css::text::XTextRange>& rRange,
+                                  const css::uno::Reference<css::frame::XController>& rController,
+                                  const css::lang::Locale& rLocale,
                                   const OUString& rApplicationName,
                                   const OUString& rRangeText ) :
     SfxPoolItem( nId ),
diff --git a/svx/source/sidebar/line/LineWidthValueSet.cxx b/svx/source/sidebar/line/LineWidthValueSet.cxx
index d4172d420267..0d7503fac64b 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.cxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.cxx
@@ -74,7 +74,7 @@ void LineWidthValueSet::SetSelItem(sal_uInt16 nSel)
     }
 }
 
-void LineWidthValueSet::SetImage(Image img)
+void LineWidthValueSet::SetImage(const Image& img)
 {
     imgCus = img;
 }
diff --git a/svx/source/sidebar/line/LineWidthValueSet.hxx b/svx/source/sidebar/line/LineWidthValueSet.hxx
index 6fb9ae5a5bd2..ca7e1041dcbf 100644
--- a/svx/source/sidebar/line/LineWidthValueSet.hxx
+++ b/svx/source/sidebar/line/LineWidthValueSet.hxx
@@ -35,7 +35,7 @@ public:
     void SetUnit(OUString* str);
     void SetSelItem(sal_uInt16 nSel);
     sal_uInt16 GetSelItem() { return nSelItem;}
-    void SetImage(Image img);
+    void SetImage(const Image& img);
     void SetCusEnable(bool bEnable);
 
     virtual void    UserDraw( const UserDrawEvent& rUDEvt ) override;
diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx
index b50f5e3dee1b..2511e5dd7a68 100644
--- a/svx/source/svdraw/svdmodel.cxx
+++ b/svx/source/svdraw/svdmodel.cxx
@@ -1820,7 +1820,7 @@ uno::Reference< uno::XInterface > SdrModel::getUnoModel()
     return mxUnoModel;
 }
 
-void SdrModel::setUnoModel( css::uno::Reference< css::uno::XInterface > xModel )
+void SdrModel::setUnoModel( const css::uno::Reference< css::uno::XInterface >& xModel )
 {
     mxUnoModel = xModel;
 }
@@ -1903,7 +1903,7 @@ void SdrModel::MigrateItemSet( const SfxItemSet* pSourceSet, SfxItemSet* pDestSe
 }
 
 
-void SdrModel::SetForbiddenCharsTable( rtl::Reference<SvxForbiddenCharactersTable> xForbiddenChars )
+void SdrModel::SetForbiddenCharsTable( const rtl::Reference<SvxForbiddenCharactersTable>& xForbiddenChars )
 {
     if( mpForbiddenCharactersTable )
         mpForbiddenCharactersTable->release();
diff --git a/svx/source/table/accessibletableshape.cxx b/svx/source/table/accessibletableshape.cxx
index 97e53b67a186..40798bb750c1 100644
--- a/svx/source/table/accessibletableshape.cxx
+++ b/svx/source/table/accessibletableshape.cxx
@@ -84,7 +84,7 @@ public:
     Reference< XAccessible> mxAccessible;
     sal_Int32 mRowCount, mColCount;
     //get the cached AccessibleCell from XCell
-    Reference< AccessibleCell > getAccessibleCell (Reference< XCell > xCell);
+    Reference< AccessibleCell > getAccessibleCell (const Reference< XCell >& xCell);
     Reference< AccessibleCell > getAccessibleCell (sal_Int32 nRow, sal_Int32 nColumn) throw (IndexOutOfBoundsException, RuntimeException);
 };
 
@@ -136,7 +136,7 @@ void AccessibleTableShapeImpl::dispose()
 
 
 //get the cached AccessibleCell from XCell
-Reference< AccessibleCell > AccessibleTableShapeImpl::getAccessibleCell (Reference< XCell > xCell)
+Reference< AccessibleCell > AccessibleTableShapeImpl::getAccessibleCell (const Reference< XCell >& xCell)
 {
     AccessibleCellMap::iterator iter( maChildMap.find( xCell ) );
 
diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx
index 430623ebc500..535134f344de 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -219,7 +219,7 @@ void PaletteManager::SetBtnUpdater(svx::ToolboxButtonColorUpdater* pBtnUpdater)
     mpBtnUpdater = pBtnUpdater;
 }
 
-void PaletteManager::SetColorSelectFunction(std::function<void(const OUString&, const Color&)> aColorSelectFunction)
+void PaletteManager::SetColorSelectFunction(const std::function<void(const OUString&, const Color&)>& aColorSelectFunction)
 {
     maColorSelectFunction = aColorSelectFunction;
 }
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index dc70581cb383..38a2f1f9b96b 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -2094,7 +2094,7 @@ struct SvxStyleToolBoxControl::Impl
 
 
     }
-    void InitializeStyles(Reference < frame::XModel > xModel)
+    void InitializeStyles(const Reference < frame::XModel >& xModel)
     {
         //now convert the default style names to the localized names
         try
@@ -2693,7 +2693,7 @@ SvxColorToolBoxControl::~SvxColorToolBoxControl()
 {
 }
 
-void SvxColorToolBoxControl::setColorSelectFunction(ColorSelectFunction aColorSelectFunction)
+void SvxColorToolBoxControl::setColorSelectFunction(const ColorSelectFunction& aColorSelectFunction)
 {
     maColorSelectFunction = aColorSelectFunction;
     mPaletteManager.SetColorSelectFunction(aColorSelectFunction);
diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx
index 558aad238ba2..c66201482d40 100644
--- a/svx/source/unodraw/unopage.cxx
+++ b/svx/source/unodraw/unopage.cxx
@@ -911,7 +911,7 @@ uno::Reference< drawing::XDrawPage > GetXDrawPageForSdrPage( SdrPage* pPage ) th
 }
 
 /** returns the SdrObject from the given StarOffice API wrapper */
-SdrPage* GetSdrPageFromXDrawPage( uno::Reference< drawing::XDrawPage > xDrawPage ) throw()
+SdrPage* GetSdrPageFromXDrawPage( const uno::Reference< drawing::XDrawPage >& xDrawPage ) throw()
 {
     if(xDrawPage.is())
     {
diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 386eeda8b1cc..bb32dd0542e5 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -594,7 +594,7 @@ void SvxShape::ForceMetricTo100th_mm(basegfx::B2DPolyPolygon& rPolyPolygon) cons
 
 
 void SvxItemPropertySet_ObtainSettingsFromPropertySet(const SvxItemPropertySet& rPropSet,
-  SfxItemSet& rSet, uno::Reference< beans::XPropertySet > xSet, const SfxItemPropertyMap* pMap )
+  SfxItemSet& rSet, const uno::Reference< beans::XPropertySet >& xSet, const SfxItemPropertyMap* pMap )
 {
     if(rPropSet.AreThereOwnUsrAnys())
     {
@@ -4135,7 +4135,7 @@ uno::Reference< drawing::XShape > GetXShapeForSdrObject( SdrObject* pObj ) throw
 }
 
 /** returns the SdrObject from the given StarOffice API wrapper */
-SdrObject* GetSdrObjectFromXShape( uno::Reference< drawing::XShape > xShape ) throw()
+SdrObject* GetSdrObjectFromXShape( const uno::Reference< drawing::XShape >& xShape ) throw()
 {
     SvxShape* pShape = SvxShape::getImplementation( xShape );
     return pShape ? pShape->GetSdrObject() : nullptr;
diff --git a/svx/source/xml/xmlxtexp.cxx b/svx/source/xml/xmlxtexp.cxx
index 1903527a9a79..5c4fbc6a6a16 100644
--- a/svx/source/xml/xmlxtexp.cxx
+++ b/svx/source/xml/xmlxtexp.cxx
@@ -188,7 +188,7 @@ static void initializeStreamMetadata( const uno::Reference< uno::XInterface > &x
 
 static void createStorageStream( uno::Reference < io::XOutputStream > *xOut,
                                  SvXMLGraphicHelper                  **ppGraphicHelper,
-                                 uno::Reference < embed::XStorage >    xSubStorage )
+                                 const uno::Reference < embed::XStorage >& xSubStorage )
 {
     uno::Reference < io::XStream > xStream;
     xStream = xSubStorage->openStreamElement(
diff --git a/svx/source/xml/xmlxtimp.cxx b/svx/source/xml/xmlxtimp.cxx
index 0183888ac50f..09746038966e 100644
--- a/svx/source/xml/xmlxtimp.cxx
+++ b/svx/source/xml/xmlxtimp.cxx
@@ -348,7 +348,7 @@ SvxXMLXTableImport::~SvxXMLXTableImport() throw ()
 
 static void openStorageStream( xml::sax::InputSource *pParserInput,
                                SvXMLGraphicHelper   **ppGraphicHelper,
-                               uno::Reference < embed::XStorage > xStorage )
+                               const uno::Reference < embed::XStorage >& xStorage )
 {
     uno::Reference < io::XStream > xIStm;
     xIStm.set( xStorage->openStreamElement( "Content.xml", embed::ElementModes::READ ), uno::UNO_QUERY_THROW );