summaryrefslogtreecommitdiff
path: root/svx
diff options
context:
space:
mode:
authorWerner Koerner <wk661lo@gmail.com>2012-12-29 12:56:02 +0100
committerTomáš Chvátal <tchvatal@suse.cz>2013-01-02 13:26:19 +0000
commitce9deff347ebdb1ab6faced894e8de9979eabb0e (patch)
tree83dd2eda95be1c0f5389bdb1c27589a02729987a /svx
parent76091d814ca084ba66fcb9db8bc4565c47ee16a5 (diff)
Change if-statements to switch
The bit-values do overlap, 3rd and 4th case were never reached. Change-Id: Iaaf39a11811c4e28c34260a7eab7fa0476165d1b Reviewed-on: https://gerrit.libreoffice.org/1497 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
Diffstat (limited to 'svx')
-rw-r--r--svx/source/items/pageitem.cxx17
1 files changed, 8 insertions, 9 deletions
diff --git a/svx/source/items/pageitem.cxx b/svx/source/items/pageitem.cxx
index e7062eee8452..67d491dedb58 100644
--- a/svx/source/items/pageitem.cxx
+++ b/svx/source/items/pageitem.cxx
@@ -84,15 +84,14 @@ int SvxPageItem::operator==( const SfxPoolItem& rAttr ) const
inline XubString GetUsageText( const sal_uInt16 eU )
{
- if ( eU & SVX_PAGE_LEFT )
- return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_LEFT);
- if ( eU & SVX_PAGE_RIGHT )
- return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_RIGHT);
- if ( eU & SVX_PAGE_ALL )
- return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_ALL);
- if ( eU & SVX_PAGE_MIRROR )
- return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_MIRROR);
- return String();
+ switch( eU & 0x000f )
+ {
+ case SVX_PAGE_LEFT : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_LEFT);
+ case SVX_PAGE_RIGHT : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_RIGHT);
+ case SVX_PAGE_ALL : return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_ALL);
+ case SVX_PAGE_MIRROR: return SVX_RESSTR(RID_SVXITEMS_PAGE_USAGE_MIRROR);
+ default: return String();
+ }
}
//------------------------------------------------------------------------