improve passstuffbyref return analysis

Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

24 files changed, 31 insertions, 31 deletions

diff --git a/svx/inc/sdr/contact/viewobjectcontactofe3d.hxx b/svx/inc/sdr/contact/viewobjectcontactofe3d.hxx
index aa58d2f19d59..ac573bf2271f 100644
--- a/svx/inc/sdr/contact/viewobjectcontactofe3d.hxx
+++ b/svx/inc/sdr/contact/viewobjectcontactofe3d.hxx
@@ -57,7 +57,7 @@ namespace sdr
             // access to the local primitive sequence. This will ensure that the list is
             // current in comparing the local list content with a fresh created incarnation
             // This method will not handle included hierarchies or visibility.
-            drawinglayer::primitive3d::Primitive3DContainer getPrimitive3DContainer(const DisplayInfo& rDisplayInfo) const;
+            drawinglayer::primitive3d::Primitive3DContainer const & getPrimitive3DContainer(const DisplayInfo& rDisplayInfo) const;
         };
     } // end of namespace contact
 } // end of namespace sdr
diff --git a/svx/source/accessibility/charmapacc.cxx b/svx/source/accessibility/charmapacc.cxx
index e8d6e054f31f..076179960179 100644
--- a/svx/source/accessibility/charmapacc.cxx
+++ b/svx/source/accessibility/charmapacc.cxx
@@ -241,7 +241,7 @@ SvxShowCharSetItem::~SvxShowCharSetItem()
 }
 
 
-uno::Reference< css::accessibility::XAccessible > SvxShowCharSetItem::GetAccessible()
+uno::Reference< css::accessibility::XAccessible > const & SvxShowCharSetItem::GetAccessible()
 {
     if( !m_xAcc.is() )
     {
diff --git a/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx b/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
index a8aab198cee6..4aa8168f91a2 100644
--- a/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
+++ b/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
@@ -830,7 +830,7 @@ Rectangle SvxPixelCtlAccessibleChild::GetBoundingBoxOnScreen() throw( RuntimeExc
     return Rectangle( mrParentWindow.OutputToAbsoluteScreenPixel( aRect.TopLeft() ), aRect.GetSize() );
 }
 
-Rectangle SvxPixelCtlAccessibleChild::GetBoundingBox() throw( RuntimeException )
+Rectangle const & SvxPixelCtlAccessibleChild::GetBoundingBox() throw( RuntimeException )
 {
     // no guard necessary, because no one changes mpBoundingBox after creating it
     ThrowExceptionIfNotAlive();
diff --git a/svx/source/accessibility/svxrectctaccessiblecontext.cxx b/svx/source/accessibility/svxrectctaccessiblecontext.cxx
index de5775bf883c..ea1404d35bcc 100644
--- a/svx/source/accessibility/svxrectctaccessiblecontext.cxx
+++ b/svx/source/accessibility/svxrectctaccessiblecontext.cxx
@@ -1073,7 +1073,7 @@ Rectangle SvxRectCtlChildAccessibleContext::GetBoundingBoxOnScreen() throw( Runt
     return Rectangle( mrParentWindow.OutputToScreenPixel( aRect.TopLeft() ), aRect.GetSize() );
 }
 
-Rectangle SvxRectCtlChildAccessibleContext::GetBoundingBox() throw( RuntimeException )
+Rectangle const & SvxRectCtlChildAccessibleContext::GetBoundingBox() throw( RuntimeException )
 {
     // no guard necessary, because no one changes mpBoundingBox after creating it
     ThrowExceptionIfNotAlive();
diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 6bc1e254a9b7..89f1d6f2413a 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -833,7 +833,7 @@ SdrObject* CreateSdrObjectFromParagraphOutlines( const FWData& rFWData, const Sd
 
 Reference < i18n::XBreakIterator > EnhancedCustomShapeFontWork::mxBreakIterator = nullptr;
 
-Reference < i18n::XBreakIterator > EnhancedCustomShapeFontWork::GetBreakIterator()
+Reference < i18n::XBreakIterator > const & EnhancedCustomShapeFontWork::GetBreakIterator()
 {
     if ( !mxBreakIterator.is() )
     {
diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.hxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.hxx
index 5e0baeae7fc5..d86388cb75fc 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.hxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.hxx
@@ -29,7 +29,7 @@ class EnhancedCustomShapeFontWork
 
     public:
 
-        static css::uno::Reference < css::i18n::XBreakIterator > GetBreakIterator();
+        static css::uno::Reference < css::i18n::XBreakIterator > const & GetBreakIterator();
         static SdrObject* CreateFontWork( const SdrObject* pShape2d, const SdrObject* pCustomShape );
 };
 
diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx
index 3335316bfa21..c52cdfbbc5a2 100644
--- a/svx/source/dialog/rubydialog.cxx
+++ b/svx/source/dialog/rubydialog.cxx
@@ -99,7 +99,7 @@ public:
     virtual ~SvxRubyData_Impl();
 
     void SetController(const Reference<XController>& xCtrl);
-    Reference<XModel> GetModel()
+    Reference<XModel> const & GetModel()
     {
         if (!xController.is())
             xModel = nullptr;
@@ -111,7 +111,7 @@ public:
     {
         return bHasSelectionChanged;
     }
-    Reference<XRubySelection> GetRubySelection()
+    Reference<XRubySelection> const & GetRubySelection()
     {
         xSelection.set(xController, UNO_QUERY);
         return xSelection;
diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx
index 1ace5b93fe11..e16e6008a4a7 100644
--- a/svx/source/form/formcontroller.cxx
+++ b/svx/source/form/formcontroller.cxx
@@ -688,7 +688,7 @@ void SAL_CALL FormController::resetted(const EventObject& rEvent) throw( Runtime
 }
 
 
-Sequence< OUString> FormController::getSupportedServiceNames_Static()
+Sequence< OUString> const & FormController::getSupportedServiceNames_Static()
 {
     static Sequence< OUString> aServices;
     if (!aServices.getLength())
diff --git a/svx/source/inc/charmapacc.hxx b/svx/source/inc/charmapacc.hxx
index 2169e9688452..02260bd3c1a2 100644
--- a/svx/source/inc/charmapacc.hxx
+++ b/svx/source/inc/charmapacc.hxx
@@ -108,8 +108,8 @@ namespace svx
         SvxShowCharSetItem( SvxShowCharSet& rParent,SvxShowCharSetAcc*  _pParent,sal_uInt16 _nPos );
         ~SvxShowCharSetItem();
 
-        css::uno::Reference< css::accessibility::XAccessible >    GetAccessible();
-         void                                                                                       ClearAccessible();
+        css::uno::Reference< css::accessibility::XAccessible > const &    GetAccessible();
+         void                                                             ClearAccessible();
     };
 
 
diff --git a/svx/source/inc/datanavi.hxx b/svx/source/inc/datanavi.hxx
index 83d44467088b..eda7ac894981 100644
--- a/svx/source/inc/datanavi.hxx
+++ b/svx/source/inc/datanavi.hxx
@@ -161,7 +161,7 @@ namespace svxform
 
         /** convert submission replace string from API value to UI value.
             Use 'none' as default. */
-        OUString toUI( const OUString& rStr ) const
+        OUString const & toUI( const OUString& rStr ) const
         {
             if( rStr == m_sDoc_API )
                 return m_sDoc_UI;
@@ -173,7 +173,7 @@ namespace svxform
 
         /** convert submission replace string from UI to API.
             Use 'none' as default. */
-        OUString toAPI( const OUString& rStr ) const
+        OUString const & toAPI( const OUString& rStr ) const
         {
             if( rStr == m_sDoc_UI )
                 return m_sDoc_API;
@@ -209,7 +209,7 @@ namespace svxform
         }
 
         /** convert from API to UI; put is default. */
-        OUString toUI( const OUString& rStr ) const
+        OUString const & toUI( const OUString& rStr ) const
         {
             if( rStr == m_sGet_API )
                 return m_sGet_UI;
@@ -220,7 +220,7 @@ namespace svxform
         }
 
         /** convert from UI to API; put is default */
-        OUString toAPI( const OUString& rStr ) const
+        OUString const & toAPI( const OUString& rStr ) const
         {
             if( rStr == m_sGet_UI )
                 return m_sGet_API;
diff --git a/svx/source/inc/formcontroller.hxx b/svx/source/inc/formcontroller.hxx
index 6db2813a6961..e93160e94172 100644
--- a/svx/source/inc/formcontroller.hxx
+++ b/svx/source/inc/formcontroller.hxx
@@ -406,7 +406,7 @@ namespace svxform
         virtual void SAL_CALL invalidateAllFeatures(  ) throw (css::uno::RuntimeException, std::exception) override;
 
 // method for registration
-        static  css::uno::Sequence< OUString >  getSupportedServiceNames_Static();
+        static  css::uno::Sequence< OUString > const &  getSupportedServiceNames_Static();
 
         // comphelper::OPropertyArrayUsageHelper
         virtual void fillProperties(
diff --git a/svx/source/inc/svxpixelctlaccessiblecontext.hxx b/svx/source/inc/svxpixelctlaccessiblecontext.hxx
index b9a572065967..07d807364eb1 100644
--- a/svx/source/inc/svxpixelctlaccessiblecontext.hxx
+++ b/svx/source/inc/svxpixelctlaccessiblecontext.hxx
@@ -135,7 +135,7 @@ public:
 
     Rectangle GetBoundingBoxOnScreen() throw( css::uno::RuntimeException );
 
-    Rectangle GetBoundingBox() throw( css::uno::RuntimeException );
+    Rectangle const & GetBoundingBox() throw( css::uno::RuntimeException );
 
     /// @returns true if it's disposed or in disposing
     inline bool IsAlive() const;
diff --git a/svx/source/inc/svxrectctaccessiblecontext.hxx b/svx/source/inc/svxrectctaccessiblecontext.hxx
index 2f3d072b3e82..f9dcc099258d 100644
--- a/svx/source/inc/svxrectctaccessiblecontext.hxx
+++ b/svx/source/inc/svxrectctaccessiblecontext.hxx
@@ -427,7 +427,7 @@ public:
 protected:
     Rectangle GetBoundingBoxOnScreen() throw( css::uno::RuntimeException );
 
-    Rectangle GetBoundingBox() throw( css::uno::RuntimeException );
+    Rectangle const & GetBoundingBox() throw( css::uno::RuntimeException );
 
     void CommitChange( const css::accessibility::AccessibleEventObject& rEvent );
 
diff --git a/svx/source/sdr/contact/viewcontact.cxx b/svx/source/sdr/contact/viewcontact.cxx
index 244aead6fb37..c4e5f11b7e3d 100644
--- a/svx/source/sdr/contact/viewcontact.cxx
+++ b/svx/source/sdr/contact/viewcontact.cxx
@@ -233,7 +233,7 @@ drawinglayer::primitive2d::Primitive2DContainer ViewContact::createViewIndepende
     return drawinglayer::primitive2d::Primitive2DContainer { xReference };
 }
 
-drawinglayer::primitive2d::Primitive2DContainer ViewContact::getViewIndependentPrimitive2DSequence() const
+drawinglayer::primitive2d::Primitive2DContainer const & ViewContact::getViewIndependentPrimitive2DSequence() const
 {
     // local up-to-date checks. Create new list and compare.
     drawinglayer::primitive2d::Primitive2DContainer xNew(createViewIndependentPrimitive2DSequence());
diff --git a/svx/source/sdr/contact/viewcontactofe3d.cxx b/svx/source/sdr/contact/viewcontactofe3d.cxx
index 9bbb61a6f1a2..253bdea07f30 100644
--- a/svx/source/sdr/contact/viewcontactofe3d.cxx
+++ b/svx/source/sdr/contact/viewcontactofe3d.cxx
@@ -135,7 +135,7 @@ ViewContactOfE3d::~ViewContactOfE3d()
 {
 }
 
-drawinglayer::primitive3d::Primitive3DContainer ViewContactOfE3d::getVIP3DSWithoutObjectTransform() const
+drawinglayer::primitive3d::Primitive3DContainer const & ViewContactOfE3d::getVIP3DSWithoutObjectTransform() const
 {
     // local up-to-date checks. Create new list and compare.
     drawinglayer::primitive3d::Primitive3DContainer xNew(createViewIndependentPrimitive3DContainer());
diff --git a/svx/source/sdr/contact/viewobjectcontact.cxx b/svx/source/sdr/contact/viewobjectcontact.cxx
index 03fbd573e82c..029abbcfae02 100644
--- a/svx/source/sdr/contact/viewobjectcontact.cxx
+++ b/svx/source/sdr/contact/viewobjectcontact.cxx
@@ -359,7 +359,7 @@ drawinglayer::primitive2d::Primitive2DContainer ViewObjectContact::createPrimiti
     return xRetval;
 }
 
-drawinglayer::primitive2d::Primitive2DContainer ViewObjectContact::getPrimitive2DSequence(const DisplayInfo& rDisplayInfo) const
+drawinglayer::primitive2d::Primitive2DContainer const & ViewObjectContact::getPrimitive2DSequence(const DisplayInfo& rDisplayInfo) const
 {
     drawinglayer::primitive2d::Primitive2DContainer xNewPrimitiveSequence;
 
diff --git a/svx/source/sdr/contact/viewobjectcontactofe3d.cxx b/svx/source/sdr/contact/viewobjectcontactofe3d.cxx
index 896a56a600a5..93cf40845dd3 100644
--- a/svx/source/sdr/contact/viewobjectcontactofe3d.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofe3d.cxx
@@ -72,7 +72,7 @@ namespace sdr
             return rViewContact.impCreateWithGivenPrimitive3DContainer(getPrimitive3DContainer(rDisplayInfo));
         }
 
-        drawinglayer::primitive3d::Primitive3DContainer ViewObjectContactOfE3d::getPrimitive3DContainer(const DisplayInfo& rDisplayInfo) const
+        drawinglayer::primitive3d::Primitive3DContainer const & ViewObjectContactOfE3d::getPrimitive3DContainer(const DisplayInfo& rDisplayInfo) const
         {
             drawinglayer::primitive3d::Primitive3DContainer xNewPrimitive3DSeq(createPrimitive3DContainer(rDisplayInfo));
 
diff --git a/svx/source/sdr/overlay/overlaymanager.cxx b/svx/source/sdr/overlay/overlaymanager.cxx
index 747a727f9cbe..043d4cacc9d5 100644
--- a/svx/source/sdr/overlay/overlaymanager.cxx
+++ b/svx/source/sdr/overlay/overlaymanager.cxx
@@ -145,7 +145,7 @@ namespace sdr
             return rtl::Reference<OverlayManager>(new OverlayManager(rOutputDevice));
         }
 
-        const drawinglayer::geometry::ViewInformation2D OverlayManager::getCurrentViewInformation2D() const
+        drawinglayer::geometry::ViewInformation2D const & OverlayManager::getCurrentViewInformation2D() const
         {
             if(getOutputDevice().GetViewTransformation() != maViewTransformation)
             {
diff --git a/svx/source/svdraw/sdrpaintwindow.cxx b/svx/source/svdraw/sdrpaintwindow.cxx
index 473da51f4508..c014ea9fc687 100644
--- a/svx/source/svdraw/sdrpaintwindow.cxx
+++ b/svx/source/svdraw/sdrpaintwindow.cxx
@@ -253,7 +253,7 @@ SdrPaintWindow::~SdrPaintWindow()
     DestroyPreRenderDevice();
 }
 
-rtl::Reference< sdr::overlay::OverlayManager > SdrPaintWindow::GetOverlayManager() const
+rtl::Reference< sdr::overlay::OverlayManager > const & SdrPaintWindow::GetOverlayManager() const
 {
     if(!mxOverlayManager.is())
     {
diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx
index 8d970297d779..240abf8bd0b3 100644
--- a/svx/source/svdraw/svdmodel.cxx
+++ b/svx/source/svdraw/svdmodel.cxx
@@ -1759,7 +1759,7 @@ void SdrModel::SetStarDrawPreviewMode(bool bPreview)
     }
 }
 
-uno::Reference< uno::XInterface > SdrModel::getUnoModel()
+uno::Reference< uno::XInterface > const & SdrModel::getUnoModel()
 {
     if( !mxUnoModel.is() )
         mxUnoModel = createUnoModel();
diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 0f4acc0f137e..799e2344a9ab 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -405,7 +405,7 @@ SdrObject* ImpCreateShadowObjectClone(const SdrObject& rOriginal, const SfxItemS
 }
 
 
-Reference< XCustomShapeEngine > SdrObjCustomShape::GetCustomShapeEngine() const
+Reference< XCustomShapeEngine > const & SdrObjCustomShape::GetCustomShapeEngine() const
 {
     if (mxCustomShapeEngine.is())
         return mxCustomShapeEngine;
diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index e6d961b3a87e..5fdb308b1a74 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -1669,7 +1669,7 @@ void SdrPage::SetUnoPage(uno::Reference<drawing::XDrawPage> const& xNewPage)
     mxUnoPage = xNewPage;
 }
 
-uno::Reference< uno::XInterface > SdrPage::getUnoPage()
+uno::Reference< uno::XInterface > const & SdrPage::getUnoPage()
 {
     if( !mxUnoPage.is() )
     {
diff --git a/svx/source/xml/xmleohlp.cxx b/svx/source/xml/xmleohlp.cxx
index 82e5ad505567..7067da149f2a 100644
--- a/svx/source/xml/xmleohlp.cxx
+++ b/svx/source/xml/xmleohlp.cxx
@@ -329,7 +329,7 @@ bool SvXMLEmbeddedObjectHelper::ImplGetStorageNames(
     return true;
 }
 
-uno::Reference < embed::XStorage > SvXMLEmbeddedObjectHelper::ImplGetContainerStorage(
+uno::Reference < embed::XStorage > const & SvXMLEmbeddedObjectHelper::ImplGetContainerStorage(
         const OUString& rStorageName )
 {
     DBG_ASSERT( -1 == rStorageName.indexOf( '/' ) &&
diff --git a/svx/source/xoutdev/xtabdash.cxx b/svx/source/xoutdev/xtabdash.cxx
index 52c2209f0a3c..40021aef04d4 100644
--- a/svx/source/xoutdev/xtabdash.cxx
+++ b/svx/source/xoutdev/xtabdash.cxx
@@ -189,7 +189,7 @@ Bitmap XDashList::CreateBitmapForUI( long nIndex )
     return ImpCreateBitmapForXDash(&rDash);
 }
 
-Bitmap XDashList::GetBitmapForUISolidLine() const
+Bitmap const & XDashList::GetBitmapForUISolidLine() const
 {
     if(maBitmapSolidLine.IsEmpty())
     {
@@ -199,7 +199,7 @@ Bitmap XDashList::GetBitmapForUISolidLine() const
     return maBitmapSolidLine;
 }
 
-OUString XDashList::GetStringForUiSolidLine() const
+OUString const & XDashList::GetStringForUiSolidLine() const
 {
     if(maStringSolidLine.isEmpty())
     {
@@ -209,7 +209,7 @@ OUString XDashList::GetStringForUiSolidLine() const
     return maStringSolidLine;
 }
 
-OUString XDashList::GetStringForUiNoLine() const
+OUString const & XDashList::GetStringForUiNoLine() const
 {
     if(maStringNoLine.isEmpty())
     {