diff options
| author | Michael Stahl <mstahl@redhat.com> | 2015-04-14 23:40:06 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2015-04-16 23:07:00 +0200 |
| commit | 951b2319e0a073c88d9e1ba67dc5db42e626aaf1 (patch) | |
| tree | 03a5aac2cc0c8a4d116efdbf1633b6c6e9055d5b /svx | |
| parent | f5e66bd5702b626bf170b46bbaa3c0eacb45de9c (diff) | |
tdf#89750: svx: fix ExternalToolEdit on Windows
While adding check that the temp file move succeeds, overlooked that the
file handle is actually leaked, which means the move will fail on WNT
because the file is already open.
(regression from ef490df2119523e1761f99b5fdbb387c2c71608d)
Change-Id: I779ccde79871930fef3bad7e17b633fb62e36a46
(cherry picked from commit 582cdc273ec0e91d27be8a7893994acadf4d7d18)
Reviewed-on: https://gerrit.libreoffice.org/15315
Tested-by: David Tardon <dtardon@redhat.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/core/extedit.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/svx/source/core/extedit.cxx b/svx/source/core/extedit.cxx index 1511fdf0b367..67bd9f0f66e2 100644 --- a/svx/source/core/extedit.cxx +++ b/svx/source/core/extedit.cxx @@ -113,9 +113,8 @@ void ExternalToolEdit::Edit(GraphicObject const*const pGraphicObject) OUString aTempFileBase; OUString aTempFileName; - oslFileHandle pHandle; osl::FileBase::RC rc = - osl::FileBase::createTempFile(0, &pHandle, &aTempFileBase); + osl::FileBase::createTempFile(nullptr, nullptr, &aTempFileBase); if (osl::FileBase::E_None != rc) { SAL_WARN("svx", "ExternalToolEdit::Edit: cannot create temp file"); |