pass ownership by pointer

to show the intend of the code.

assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.

Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

6 files changed, 23 insertions, 23 deletions

diff --git a/svx/source/svdraw/svdcrtv.cxx b/svx/source/svdraw/svdcrtv.cxx
index d3b0a2872eea..3dcda7360448 100644
--- a/svx/source/svdraw/svdcrtv.cxx
+++ b/svx/source/svdraw/svdcrtv.cxx
@@ -77,7 +77,7 @@ ImplConnectMarkerOverlay::ImplConnectMarkerOverlay(const SdrCreateView& rView, S
             sdr::overlay::OverlayPolyPolygonStripedAndFilled* pNew = new sdr::overlay::OverlayPolyPolygonStripedAndFilled(
                 aB2DPolyPolygon);
             xTargetOverlay->add(*pNew);
-            maObjects.append(*pNew);
+            maObjects.append(pNew);
 
             // glue points
             for(sal_uInt16 i(0); i < 4; i++)
@@ -101,7 +101,7 @@ ImplConnectMarkerOverlay::ImplConnectMarkerOverlay(const SdrCreateView& rView, S
                 pNew = new sdr::overlay::OverlayPolyPolygonStripedAndFilled(
                     aTempPolyPoly);
                 xTargetOverlay->add(*pNew);
-                maObjects.append(*pNew);
+                maObjects.append(pNew);
             }
         }
     }
@@ -153,7 +153,7 @@ void ImpSdrCreateViewExtraData::CreateAndShowOverlay(const SdrCreateView& rView,
                 sdr::overlay::OverlayObject* pNew = new sdr::overlay::OverlayPrimitive2DSequenceObject(aSequence);
 
                 xOverlayManager->add(*pNew);
-                maObjects.append(*pNew);
+                maObjects.append(pNew);
             }
 
             if(rPolyPoly.count())
@@ -161,7 +161,7 @@ void ImpSdrCreateViewExtraData::CreateAndShowOverlay(const SdrCreateView& rView,
                 sdr::overlay::OverlayPolyPolygonStripedAndFilled* pNew = new sdr::overlay::OverlayPolyPolygonStripedAndFilled(
                     rPolyPoly);
                 xOverlayManager->add(*pNew);
-                maObjects.append(*pNew);
+                maObjects.append(pNew);
             }
         }
     }
diff --git a/svx/source/svdraw/svddrgmt.cxx b/svx/source/svdraw/svddrgmt.cxx
index 34b3a8b7a1a4..50d4da0800ff 100644
--- a/svx/source/svdraw/svddrgmt.cxx
+++ b/svx/source/svdraw/svddrgmt.cxx
@@ -788,7 +788,7 @@ void SdrDragMethod::CreateOverlayGeometry(sdr::overlay::OverlayManager& rOverlay
         {
             sdr::overlay::OverlayObject* pNewOverlayObject = new sdr::overlay::OverlayPrimitive2DSequenceObject(aResult);
             rOverlayManager.add(*pNewOverlayObject);
-            addToOverlayObjectList(*pNewOverlayObject);
+            addToOverlayObjectList(pNewOverlayObject);
         }
 
         if(!aResultTransparent.empty())
@@ -798,7 +798,7 @@ void SdrDragMethod::CreateOverlayGeometry(sdr::overlay::OverlayManager& rOverlay
 
             sdr::overlay::OverlayObject* pNewOverlayObject = new sdr::overlay::OverlayPrimitive2DSequenceObject(aResultTransparent);
             rOverlayManager.add(*pNewOverlayObject);
-            addToOverlayObjectList(*pNewOverlayObject);
+            addToOverlayObjectList(pNewOverlayObject);
         }
     }
 
@@ -814,7 +814,7 @@ void SdrDragMethod::CreateOverlayGeometry(sdr::overlay::OverlayManager& rOverlay
             aTopLeft, aBottomRight, true, false);
 
         rOverlayManager.add(*pNew);
-        addToOverlayObjectList(*pNew);
+        addToOverlayObjectList(pNew);
     }
 }
 
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 2f8a46854969..0b51b7ccf9f9 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -630,7 +630,7 @@ void SdrHdl::CreateB2dIAObject()
                         if (pNewOverlayObject)
                         {
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -1142,7 +1142,7 @@ void SdrHdlColor::CreateB2dIAObject()
 
                             // OVERLAYMANAGER
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -1307,7 +1307,7 @@ void SdrHdlGradient::CreateB2dIAObject()
 
                             pNewOverlayObject->setBaseColor(IsGradient() ? Color(COL_BLACK) : Color(COL_BLUE));
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
 
                             // arrowhead
                             Point aLeft(aMidPoint.X() + (sal_Int32)(aPerpend.getX() * fHalfArrowWidth),
@@ -1329,7 +1329,7 @@ void SdrHdlGradient::CreateB2dIAObject()
                             DBG_ASSERT(pNewOverlayObject, "Got NO new IAO!");
 
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -1457,7 +1457,7 @@ void SdrHdlLine::CreateB2dIAObject()
                             pNewOverlayObject->setBaseColor(Color(COL_LIGHTRED));
 
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -1517,7 +1517,7 @@ void SdrHdlBezWgt::CreateB2dIAObject()
                                 pNewOverlayObject->setBaseColor(Color(COL_LIGHTBLUE));
 
                                 xManager->add(*pNewOverlayObject);
-                                maOverlayGroup.append(*pNewOverlayObject);
+                                maOverlayGroup.append(pNewOverlayObject);
                             }
                         }
                     }
@@ -1563,7 +1563,7 @@ void E3dVolumeMarker::CreateB2dIAObject()
                             pNewOverlayObject->setBaseColor(Color(COL_BLACK));
 
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -1629,7 +1629,7 @@ void ImpEdgeHdl::CreateB2dIAObject()
                                 if (pNewOverlayObject)
                                 {
                                     xManager->add(*pNewOverlayObject);
-                                    maOverlayGroup.append(*pNewOverlayObject);
+                                    maOverlayGroup.append(pNewOverlayObject);
                                 }
                             }
                         }
@@ -1750,7 +1750,7 @@ void ImpMeasureHdl::CreateB2dIAObject()
                             if (pNewOverlayObject)
                             {
                                 xManager->add(*pNewOverlayObject);
-                                maOverlayGroup.append(*pNewOverlayObject);
+                                maOverlayGroup.append(pNewOverlayObject);
                             }
                         }
                     }
@@ -1821,7 +1821,7 @@ void ImpTextframeHdl::CreateB2dIAObject()
                             // OVERLAYMANAGER
                             pNewOverlayObject->setHittable(false);
                             xManager->add(*pNewOverlayObject);
-                            maOverlayGroup.append(*pNewOverlayObject);
+                            maOverlayGroup.append(pNewOverlayObject);
                         }
                     }
                 }
@@ -2437,7 +2437,7 @@ void SdrCropHdl::CreateB2dIAObject()
                     if(pOverlayObject)
                     {
                         xManager->add(*pOverlayObject);
-                        maOverlayGroup.append(*pOverlayObject);
+                        maOverlayGroup.append(pOverlayObject);
                     }
                 }
             }
@@ -2651,7 +2651,7 @@ void SdrCropViewHdl::CreateB2dIAObject()
                 pNew->setHittable(false);
 
                 xManager->add(*pNew);
-                maOverlayGroup.append(*pNew);
+                maOverlayGroup.append(pNew);
             }
         }
     }
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index c379541d4dd8..d02747a0c177 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -93,7 +93,7 @@ ImplMarkingOverlay::ImplMarkingOverlay(const SdrPaintView& rView, const basegfx:
             sdr::overlay::OverlayRollingRectangleStriped* pNew = new sdr::overlay::OverlayRollingRectangleStriped(
                 rStartPos, rStartPos, false);
             xTargetOverlay->add(*pNew);
-            maObjects.append(*pNew);
+            maObjects.append(pNew);
         }
     }
 }
diff --git a/svx/source/svdraw/svdsnpv.cxx b/svx/source/svdraw/svdsnpv.cxx
index bacf45228936..3d6167d8dd5a 100644
--- a/svx/source/svdraw/svdsnpv.cxx
+++ b/svx/source/svdraw/svdsnpv.cxx
@@ -62,7 +62,7 @@ ImplPageOriginOverlay::ImplPageOriginOverlay(const SdrPaintView& rView, const ba
             sdr::overlay::OverlayCrosshairStriped* aNew = new sdr::overlay::OverlayCrosshairStriped(
                 maPosition);
             xTargetOverlay->add(*aNew);
-            maObjects.append(*aNew);
+            maObjects.append(aNew);
         }
     }
 }
@@ -140,7 +140,7 @@ ImplHelpLineOverlay::ImplHelpLineOverlay(
             sdr::overlay::OverlayHelplineStriped* aNew = new sdr::overlay::OverlayHelplineStriped(
                 maPosition, meHelpLineKind);
             xTargetOverlay->add(*aNew);
-            maObjects.append(*aNew);
+            maObjects.append(aNew);
         }
     }
 }
diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx
index ace5cef55ebd..f69d59242cc7 100644
--- a/svx/source/svdraw/svdview.cxx
+++ b/svx/source/svdraw/svdview.cxx
@@ -104,7 +104,7 @@ void SdrDropMarkerOverlay::ImplCreateOverlays(
                 rLinePolyPolygon);
 
             xTargetOverlay->add(*pNew);
-            maObjects.append(*pNew);
+            maObjects.append(pNew);
         }
     }
 }