diff options
| author | Noel Grandin <noel@peralex.com> | 2015-07-03 11:31:14 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-07-06 07:04:50 +0000 |
| commit | e9c3583c2cc27fc88ee81047c236ec99dd51e8de (patch) | |
| tree | b3e8394ca1ec402a31b227339366fc790124c1f8 /svx/source/svdraw | |
| parent | 89c77994d4638c86635c70535fab6508e2f3d900 (diff) | |
improve the returnbyref loplugin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'svx/source/svdraw')
| -rw-r--r-- | svx/source/svdraw/svdobj.cxx | 2 | ||||
| -rw-r--r-- | svx/source/svdraw/svdobjplusdata.cxx | 2 | ||||
| -rw-r--r-- | svx/source/svdraw/svdobjuserdatalist.cxx | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx index 9bf94f7fe8eb..d00a5036a457 100644 --- a/svx/source/svdraw/svdobj.cxx +++ b/svx/source/svdraw/svdobj.cxx @@ -2765,7 +2765,7 @@ sal_uInt16 SdrObject::GetUserDataCount() const SdrObjUserData* SdrObject::GetUserData(sal_uInt16 nNum) const { if (pPlusData==NULL || pPlusData->pUserDataList==NULL) return NULL; - return pPlusData->pUserDataList->GetUserData(nNum); + return &pPlusData->pUserDataList->GetUserData(nNum); } void SdrObject::AppendUserData(SdrObjUserData* pData) diff --git a/svx/source/svdraw/svdobjplusdata.cxx b/svx/source/svdraw/svdobjplusdata.cxx index e9d069600aee..6fbc5cf8ec22 100644 --- a/svx/source/svdraw/svdobjplusdata.cxx +++ b/svx/source/svdraw/svdobjplusdata.cxx @@ -36,7 +36,7 @@ SdrObjPlusData* SdrObjPlusData::Clone(SdrObject* pObj1) const if (nCount!=0) { pNeuPlusData->pUserDataList=new SdrObjUserDataList; for (sal_uInt16 i=0; i<nCount; i++) { - SdrObjUserData* pNeuUserData=pUserDataList->GetUserData(i)->Clone(pObj1); + SdrObjUserData* pNeuUserData=pUserDataList->GetUserData(i).Clone(pObj1); if (pNeuUserData!=NULL) { pNeuPlusData->pUserDataList->AppendUserData(pNeuUserData); } else { diff --git a/svx/source/svdraw/svdobjuserdatalist.cxx b/svx/source/svdraw/svdobjuserdatalist.cxx index c7d24ddb8a58..59d727fef4c1 100644 --- a/svx/source/svdraw/svdobjuserdatalist.cxx +++ b/svx/source/svdraw/svdobjuserdatalist.cxx @@ -17,9 +17,9 @@ size_t SdrObjUserDataList::GetUserDataCount() const return maList.size(); } -SdrObjUserData* SdrObjUserDataList::GetUserData(size_t nNum) +SdrObjUserData& SdrObjUserDataList::GetUserData(size_t nNum) { - return &maList.at(nNum); + return maList.at(nNum); } void SdrObjUserDataList::AppendUserData(SdrObjUserData* pData) |