diff options
| author | Luboš Luňák <l.lunak@suse.cz> | 2011-03-25 17:33:24 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@suse.cz> | 2011-03-25 17:33:24 +0100 |
| commit | 0527adbab1eca41ae6aeefa6e63c2e02a796c111 (patch) | |
| tree | 7e010b157c25b63f38a1999047d3891e6c3b77fc /svx/source/svdraw/svdocapt.cxx | |
| parent | e71901089adf1ec3d62fef0c6c07559381e5a551 (diff) | |
more sensible SdrObject::Clone() and SdrObject::operator=()
Virtual operator=() is IMO pointless, and especially in a class hierarchy
like SdrObject it's pretty unlikely one could reasonably assign any
SdrObject-based object to any other one. Moreover, it was actually
only used in Clone(), which was almost never reimplemented, so the
more sensible choice is to have non-virtual operator= and virtual
Clone() always being reimplemented and using that.
This commit also fixes various smaller or bigger, er, interesting
details in the various operator= implementations.
Diffstat (limited to 'svx/source/svdraw/svdocapt.cxx')
| -rwxr-xr-x | svx/source/svdraw/svdocapt.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/svx/source/svdraw/svdocapt.cxx b/svx/source/svdraw/svdocapt.cxx index 0bad6f44213b..bbba009800e8 100755 --- a/svx/source/svdraw/svdocapt.cxx +++ b/svx/source/svdraw/svdocapt.cxx @@ -251,10 +251,9 @@ sal_uInt16 SdrCaptionObj::GetObjIdentifier() const return sal_uInt16(OBJ_CAPTION); } -void SdrCaptionObj::operator=(const SdrObject& rObj) +SdrCaptionObj* SdrCaptionObj::Clone() const { - SdrRectObj::operator=(rObj); - aTailPoly=((SdrCaptionObj&)rObj).aTailPoly; + return CloneHelper< SdrCaptionObj >(); } void SdrCaptionObj::TakeObjNameSingul(XubString& rName) const |