diff options
| author | Maxim Monastirsky <momonasmon@gmail.com> | 2015-07-21 10:58:39 +0300 |
|---|---|---|
| committer | Maxim Monastirsky <momonasmon@gmail.com> | 2015-07-21 17:36:09 +0300 |
| commit | 74cc3fbc17235f5c0010c363342a9a9adaf85c4e (patch) | |
| tree | 102212f766aa8a0abd5691b15e37e48462360ae7 /svx/sdi | |
| parent | 3c7a7b538e8ca8b310ae9778ae9ace5ae937a4f1 (diff) | |
tdf#36796 Status updates for custom shapes buttons
We're dealing here with 2 bugs:
1. Single shape buttons (like rectangle, ellipse etc.) don't get
the pressed state when active. The cause is that all commands of
the same kind (Basic Shapes, Symbol Shapes etc.) are handled as
one internally, allowing only one type of status updates. It used
to transport the current active shape, but it was changed to a
boolean value in the fix for i#41753, and since then used for
the pressed state of the group buttons.
2. The pressed state of a group button shows always, even when a
user activates a shape from a place other than the drop-down
of that button. But in this case the image of the group button
doesn't update with the current shape, thus confusing the user on
what is currently active. The cause here is that we use (since
i#41753) the XSubToolbarController interface to update the last
selected function (instead of the old-style status based update),
and ToolBarManager notifies a controller about a new selection
only if it was made from a particular toolbar that the controller
claimed to use in the getSubToolbarName method.
Since 7352a7c17875e5adcc4226c45f4a03e11c44ff49 there is a similar
regression for other group buttons in sd (like lines, 3D Objects
and other), with the same cause. This is also fixed now.
Change-Id: Ida074a001ff78bf5bd5bcb8151516daa6e27cbce
Diffstat (limited to 'svx/sdi')
| -rw-r--r-- | svx/sdi/svx.sdi | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi index fe52a8c12291..91a7662cddb8 100644 --- a/svx/sdi/svx.sdi +++ b/svx/sdi/svx.sdi @@ -14174,7 +14174,7 @@ SfxBoolItem BasicShapes SID_DRAWTBX_CS_BASIC Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, @@ -14202,7 +14202,7 @@ SfxBoolItem SymbolShapes SID_DRAWTBX_CS_SYMBOL Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, @@ -14230,7 +14230,7 @@ SfxBoolItem ArrowShapes SID_DRAWTBX_CS_ARROW Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, @@ -14258,7 +14258,7 @@ SfxBoolItem FlowChartShapes SID_DRAWTBX_CS_FLOWCHART Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, @@ -14286,7 +14286,7 @@ SfxBoolItem CalloutShapes SID_DRAWTBX_CS_CALLOUT Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, @@ -14314,7 +14314,7 @@ SfxBoolItem StarShapes SID_DRAWTBX_CS_STAR Synchron; /* status: */ - SlotType = SfxBoolItem + SlotType = SfxStringItem /* config: */ AccelConfig = TRUE, |