diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-12-18 09:54:02 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-12-18 22:14:17 +0100 |
| commit | a7c772566bb8ac6a088b808cf0ef550e7b06560b (patch) | |
| tree | 56dd899b4e2081d74ea590e95e70f83f64954c48 /svx/inc | |
| parent | 877ede68f31a25a76c89d47389a190b75df1757d (diff) | |
coverity#1426163 Improper use of negative value
started life as sal_uIntPtr and the various checks are typically
nPos < thing.size() just checking one bound, so sal_uInt32 looks safer
after all
Change-Id: Ibac839fc45b10d96ce4d4c8002fd26b20f70ae1c
Reviewed-on: https://gerrit.libreoffice.org/46697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'svx/inc')
| -rw-r--r-- | svx/inc/galbrws2.hxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/svx/inc/galbrws2.hxx b/svx/inc/galbrws2.hxx index 01c7f1e6f708..cbfef1097bfc 100644 --- a/svx/inc/galbrws2.hxx +++ b/svx/inc/galbrws2.hxx @@ -100,7 +100,7 @@ private: VclPtr<GalleryToolBox> maViewBox; VclPtr<FixedLine> maSeparator; VclPtr<FixedText> maInfoBar; - sal_uIntPtr mnCurActionPos; + sal_uInt32 mnCurActionPos; GalleryBrowserMode meMode; GalleryBrowserMode meLastMode; @@ -111,8 +111,8 @@ private: void ImplUpdateViews( sal_uInt16 nSelectionId ); void ImplUpdateInfoBar(); - sal_Int32 ImplGetSelectedItemId( const Point* pSelPosPixel, Point& rSelPos ); - void ImplSelectItemId( sal_uIntPtr nItemId ); + sal_uInt32 ImplGetSelectedItemId( const Point* pSelPosPixel, Point& rSelPos ); + void ImplSelectItemId(sal_uInt32 nItemId); // Control virtual void Resize() override; |