diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2021-12-05 22:59:31 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2021-12-06 22:19:12 +0100 |
| commit | 11c2d56b290200fab69956d718f8c5f5c5f2b412 (patch) | |
| tree | b77997847cfaa90962af94261503349a11d57260 /svl | |
| parent | 47198583da8e67e0178466205d82835c391c8d73 (diff) | |
make it clearer that ScHint is modified
It's somewhat confusing that an accessor is provided to give
a reference to internal data and then the object is modified
indirectly using the reference. It appears to be only for
performance reasons, so I thought that inlining the ctor and
ctor could help the compiler to optimize this, but apparently
it can't move this outside of the loop, so at least make it
clearer.
Change-Id: I72cf15d1446daa559ac4079b9478e53694d7d198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126394
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126447
Diffstat (limited to 'svl')
| -rw-r--r-- | svl/Library_svl.mk | 1 | ||||
| -rw-r--r-- | svl/source/notify/hint.cxx | 26 |
2 files changed, 0 insertions, 27 deletions
diff --git a/svl/Library_svl.mk b/svl/Library_svl.mk index b81660089ea0..4e388ca0d471 100644 --- a/svl/Library_svl.mk +++ b/svl/Library_svl.mk @@ -168,7 +168,6 @@ $(eval $(call gb_Library_add_exception_objects,svl,\ svl/source/misc/urihelper \ svl/source/notify/SfxBroadcaster \ svl/source/notify/broadcast \ - svl/source/notify/hint \ svl/source/notify/isethint \ svl/source/notify/listener \ svl/source/notify/lstner \ diff --git a/svl/source/notify/hint.cxx b/svl/source/notify/hint.cxx deleted file mode 100644 index 72cac43ef9a9..000000000000 --- a/svl/source/notify/hint.cxx +++ /dev/null @@ -1,26 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#include <svl/hint.hxx> - -// virtual dtor for the typical base-class Hint - -SfxHint::~SfxHint() COVERITY_NOEXCEPT_FALSE {} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |