diff options
| author | Justin Luth <justin.luth@collabora.com> | 2018-05-15 10:15:01 +0300 |
|---|---|---|
| committer | Justin Luth <justin_luth@sil.org> | 2018-05-16 07:24:42 +0200 |
| commit | 5dcb065d24fd9b57b6dc65a19a8a8c8bbaa22c44 (patch) | |
| tree | ef8801a3d83867c182cb497a679c29af8abb08ed /svl | |
| parent | d57c6f5d44ec7a8dff2121bd19103804329af66a (diff) | |
NFC: unassigned variable pNewItem is always nullptr
In 2015 commit 2ebd79b3d214c62c0997606115ebc50700d6a760 a
possible initialization of the variable was removed. So
at this point pNewItem must return false.
Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09
Reviewed-on: https://gerrit.libreoffice.org/54395
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'svl')
| -rw-r--r-- | svl/source/items/itemprop.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svl/source/items/itemprop.cxx b/svl/source/items/itemprop.cxx index fd22a4f68733..98c19b200d90 100644 --- a/svl/source/items/itemprop.cxx +++ b/svl/source/items/itemprop.cxx @@ -218,7 +218,7 @@ void SfxItemPropertySet::setPropertyValue( const SfxItemPropertySimpleEntry& rEn SfxItemState eState = rSet.GetItemState( rEntry.nWID, true, &pItem ); if (SfxItemState::SET != eState && SfxItemPool::IsWhich(rEntry.nWID)) pItem = &rSet.GetPool()->GetDefaultItem(rEntry.nWID); - if(!pNewItem && pItem) + if (pItem) { pNewItem.reset(pItem->Clone()); } |