diff options
| author | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:39:24 +0100 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2015-03-11 16:50:03 +0100 |
| commit | 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba (patch) | |
| tree | 3959801825b12a5def0a4e6402917a455aa9c6a2 /svl | |
| parent | a7b9167235d38130aab1af4bed66b6c48d375fc9 (diff) | |
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
Diffstat (limited to 'svl')
| -rw-r--r-- | svl/source/config/ctloptions.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/svl/source/config/ctloptions.cxx b/svl/source/config/ctloptions.cxx index 3cca42821a50..b2e79acc54fe 100644 --- a/svl/source/config/ctloptions.cxx +++ b/svl/source/config/ctloptions.cxx @@ -128,8 +128,7 @@ SvtCTLOptions_Impl::SvtCTLOptions_Impl() : } SvtCTLOptions_Impl::~SvtCTLOptions_Impl() { - if ( IsModified() ) - Commit(); + assert(!IsModified()); // should have been committed } void SvtCTLOptions_Impl::Notify( const Sequence< OUString >& ) |