Remove non-const Sequence::begin()/end() in internal code

... to avoid hidden cost of multiple COW checks, because they
call getArray() internally.
This obsoletes [loplugin:sequenceloop].

Also rename toNonConstRange to asNonConstRange, to reflect that
the result is a view of the sequence, not an independent object.

TODO: also drop non-const operator[], but introduce operator[]
in SequenceRange.

Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/svl/source/misc/PasswordHelper.cxx b/svl/source/misc/PasswordHelper.cxx
index 617aeafdae1b..047d0b09b88b 100644
--- a/svl/source/misc/PasswordHelper.cxx
+++ b/svl/source/misc/PasswordHelper.cxx
@@ -32,7 +32,7 @@ void SvPasswordHelper::GetHashPasswordSHA256(uno::Sequence<sal_Int8>& rPassHash,
         reinterpret_cast<unsigned char const*>(tmp.getStr()), tmp.getLength(),
         ::comphelper::HashType::SHA256));
     rPassHash.realloc(hash.size());
-    ::std::copy(hash.begin(), hash.end(), rPassHash.begin());
+    ::std::copy(hash.begin(), hash.end(), rPassHash.getArray());
     rtl_secureZeroMemory(const_cast<char *>(tmp.getStr()), tmp.getLength());
 }
 
@@ -43,7 +43,7 @@ void SvPasswordHelper::GetHashPasswordSHA1UTF8(uno::Sequence<sal_Int8>& rPassHas
         reinterpret_cast<unsigned char const*>(tmp.getStr()), tmp.getLength(),
         ::comphelper::HashType::SHA1));
     rPassHash.realloc(hash.size());
-    ::std::copy(hash.begin(), hash.end(), rPassHash.begin());
+    ::std::copy(hash.begin(), hash.end(), rPassHash.getArray());
     rtl_secureZeroMemory(const_cast<char *>(tmp.getStr()), tmp.getLength());
 }