diff options
| author | Michael Meeks <michael.meeks@collabora.com> | 2014-06-16 22:27:00 +0100 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2014-06-17 15:29:10 +0100 |
| commit | 1ca7ac128dcdf03e3749af7458beac8d2da8a708 (patch) | |
| tree | d9ae82594a7822a2e5ff8921b7406d5179397cb6 /svl/CppunitTest_svl_itempool.mk | |
| parent | a15715c34309416e76ebd2007a51ff6c42f28817 (diff) | |
fdo#38513 - Accelerate non-poolable item add / remove.
For large documents we create and destroy a large number of non-poolable
SfxPoolItems, which get inserted into and removed from a vector.
Unfortunately the performance of this (depending on pattern) is O(N) and
this insert/remove/extend pattern can happen per text span we insert.
This patch makes this O(const) via a hash. This gives a 5x speedup for
the above bug; 176s to 34s or so, and moves the remaining performance
issues elsewhere.
Unfortunately, we have to retain the ordered array to keep the binary
file format code (used for editeng cut-and-paste) in place, so have to
keep both a hash, and an array, and a list around for free slots. cf.
fdo#79851 where there is a start at removing that.
This wastes space; but not that much - for a large open document
collection we have O(100's) of SfxItemPools, and O(1000's) of
SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this.
Add skeletal unit test; translate several German comments; remove
un-necessary include.
Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531
Diffstat (limited to 'svl/CppunitTest_svl_itempool.mk')
| -rw-r--r-- | svl/CppunitTest_svl_itempool.mk | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/svl/CppunitTest_svl_itempool.mk b/svl/CppunitTest_svl_itempool.mk new file mode 100644 index 000000000000..4b594989f855 --- /dev/null +++ b/svl/CppunitTest_svl_itempool.mk @@ -0,0 +1,36 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_CppunitTest_CppunitTest,svl_itempool)) + +$(eval $(call gb_CppunitTest_use_external,svl_itempool,boost_headers)) + +$(eval $(call gb_CppunitTest_use_api,svl_itempool, \ + offapi \ + udkapi \ +)) + +$(eval $(call gb_CppunitTest_add_exception_objects,svl_itempool, \ + svl/qa/unit/items/test_itempool \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,svl_itempool, \ + svl \ + comphelper \ + sal \ + cppu \ + cppuhelper \ +)) + +$(eval $(call gb_CppunitTest_set_include,svl_itempool,\ + -I$(SRCDIR)/svl/source/inc \ + $$(INCLUDE) \ +)) + +# vim: set noet sw=4 ts=4: |