diff options
| author | Noel Grandin <noel@peralex.com> | 2016-02-19 10:52:20 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-02-19 11:23:57 +0000 |
| commit | 778e9a65bf5af07c4caeff969a0324e43a78e66b (patch) | |
| tree | a5204f0d3eaf2f512a627eeb9e74d42e7e80b54f /svgio | |
| parent | 541c4c4509863beb7babe361b31e27f7295e3069 (diff) | |
new loplugin: find write-only fields
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717
Reviewed-on: https://gerrit.libreoffice.org/22498
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'svgio')
| -rw-r--r-- | svgio/inc/svgio/svgreader/svgtools.hxx | 5 | ||||
| -rw-r--r-- | svgio/source/svgreader/svgsvgnode.cxx | 4 | ||||
| -rw-r--r-- | svgio/source/svgreader/svgtools.cxx | 4 |
3 files changed, 4 insertions, 9 deletions
diff --git a/svgio/inc/svgio/svgreader/svgtools.hxx b/svgio/inc/svgio/svgreader/svgtools.hxx index a9dba7f2cdbf..82f6d0034422 100644 --- a/svgio/inc/svgio/svgreader/svgtools.hxx +++ b/svgio/inc/svgio/svgreader/svgtools.hxx @@ -157,22 +157,19 @@ namespace svgio SvgAlign maSvgAlign; /// bitfield - bool mbDefer : 1; // default is false bool mbMeetOrSlice : 1; // true = meet (default), false = slice bool mbSet : 1; public: SvgAspectRatio() : maSvgAlign(Align_xMidYMid), - mbDefer(false), mbMeetOrSlice(true), mbSet(false) { } - SvgAspectRatio(SvgAlign aSvgAlign, bool bDefer, bool bMeetOrSlice) + SvgAspectRatio(SvgAlign aSvgAlign, bool bMeetOrSlice) : maSvgAlign(aSvgAlign), - mbDefer(bDefer), mbMeetOrSlice(bMeetOrSlice), mbSet(true) { diff --git a/svgio/source/svgreader/svgsvgnode.cxx b/svgio/source/svgreader/svgsvgnode.cxx index 79697c16a455..400d480d19c2 100644 --- a/svgio/source/svgreader/svgsvgnode.cxx +++ b/svgio/source/svgreader/svgsvgnode.cxx @@ -417,7 +417,7 @@ namespace svgio // create mapping // #i122610 SVG 1.1 defines in section 5.1.2 that if the attribute perserveAspectRatio is not specified, // then the effect is as if a value of 'xMidYMid meet' were specified. - SvgAspectRatio aRatioDefault(Align_xMidYMid,false,true); + SvgAspectRatio aRatioDefault(Align_xMidYMid,true); const SvgAspectRatio& rRatio = getSvgAspectRatio().isSet()? getSvgAspectRatio() : aRatioDefault; // let mapping be created from SvgAspectRatio @@ -527,7 +527,7 @@ namespace svgio // create mapping // SVG 1.1 defines in section 5.1.2 that if the attribute perserveAspectRatio is not specified, // then the effect is as if a value of 'xMidYMid meet' were specified. - SvgAspectRatio aRatioDefault(Align_xMidYMid,false,true); + SvgAspectRatio aRatioDefault(Align_xMidYMid,true); const SvgAspectRatio& rRatio = getSvgAspectRatio().isSet()? getSvgAspectRatio() : aRatioDefault; basegfx::B2DHomMatrix aViewBoxMapping; diff --git a/svgio/source/svgreader/svgtools.cxx b/svgio/source/svgreader/svgtools.cxx index a4e4233a805d..db5e16332559 100644 --- a/svgio/source/svgreader/svgtools.cxx +++ b/svgio/source/svgreader/svgtools.cxx @@ -1304,7 +1304,6 @@ namespace svgio { sal_Int32 nPos(0); SvgAlign aSvgAlign(Align_xMidYMid); - bool bDefer(false); bool bMeetOrSlice(true); bool bChanged(false); @@ -1321,7 +1320,6 @@ namespace svgio { case SVGTokenDefer: { - bDefer = true; bChanged = true; break; } @@ -1413,7 +1411,7 @@ namespace svgio if(bChanged) { - return SvgAspectRatio(aSvgAlign, bDefer, bMeetOrSlice); + return SvgAspectRatio(aSvgAlign, bMeetOrSlice); } } |