Removed some unused parameters; added SAL_UNUSED_PARAMETER.

SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.

9 files changed, 19 insertions, 13 deletions

diff --git a/stoc/source/defaultregistry/defaultregistry.cxx b/stoc/source/defaultregistry/defaultregistry.cxx
index da291d219a03..a385426f73ff 100644
--- a/stoc/source/defaultregistry/defaultregistry.cxx
+++ b/stoc/source/defaultregistry/defaultregistry.cxx
@@ -1380,7 +1380,8 @@ void SAL_CALL NestedRegistryImpl::mergeKey( const OUString& aKeyName, const OUSt
 namespace stoc_bootstrap
 {
 //*************************************************************************
-Reference<XInterface> SAL_CALL NestedRegistry_CreateInstance( const Reference<XComponentContext>& )
+Reference<XInterface> SAL_CALL NestedRegistry_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference<XComponentContext>& )
     throw(Exception)
 {
     Reference<XInterface>   xRet;
diff --git a/stoc/source/inspect/introspection.cxx b/stoc/source/inspect/introspection.cxx
index 1cb278df6bc8..aad88991bfaf 100644
--- a/stoc/source/inspect/introspection.cxx
+++ b/stoc/source/inspect/introspection.cxx
@@ -2899,7 +2899,8 @@ Reference< XInterface > SAL_CALL ImplIntrospection_CreateInstance( const Referen
 extern "C"
 {
 SAL_DLLPUBLIC_EXPORT void * SAL_CALL component_getFactory(
-    const sal_Char * pImplName, void * pServiceManager, void * )
+    const sal_Char * pImplName, void * pServiceManager,
+    SAL_UNUSED_PARAMETER void * )
 {
     void * pRet = 0;
 
diff --git a/stoc/source/namingservice/namingservice.cxx b/stoc/source/namingservice/namingservice.cxx
index 2fbdac03cb92..55a42d5bd832 100644
--- a/stoc/source/namingservice/namingservice.cxx
+++ b/stoc/source/namingservice/namingservice.cxx
@@ -120,7 +120,8 @@ public:
 };
 
 //==================================================================================================
-static Reference<XInterface> SAL_CALL NamingService_Impl_create( const Reference<XComponentContext> & )
+static Reference<XInterface> SAL_CALL NamingService_Impl_create(
+    SAL_UNUSED_PARAMETER const Reference<XComponentContext> & )
 {
     return *new NamingService_Impl();
 }
diff --git a/stoc/source/proxy_factory/proxyfac.cxx b/stoc/source/proxy_factory/proxyfac.cxx
index 1c6c5569f213..f1fcf6c264b3 100644
--- a/stoc/source/proxy_factory/proxyfac.cxx
+++ b/stoc/source/proxy_factory/proxyfac.cxx
@@ -481,7 +481,7 @@ Sequence< OUString > FactoryImpl::getSupportedServiceNames()
 
 //==============================================================================
 static Reference< XInterface > SAL_CALL proxyfac_create(
-    Reference< XComponentContext > const & )
+    SAL_UNUSED_PARAMETER Reference< XComponentContext > const & )
     throw (Exception)
 {
     Reference< XInterface > xRet;
diff --git a/stoc/source/simpleregistry/simpleregistry.cxx b/stoc/source/simpleregistry/simpleregistry.cxx
index d396e08f9a64..f09b204e19fb 100644
--- a/stoc/source/simpleregistry/simpleregistry.cxx
+++ b/stoc/source/simpleregistry/simpleregistry.cxx
@@ -1300,7 +1300,8 @@ void SimpleRegistry::mergeKey(
 namespace stoc_bootstrap {
 
 css::uno::Reference< css::uno::XInterface > SimpleRegistry_CreateInstance(
-    css::uno::Reference< css::uno::XComponentContext > const &)
+    SAL_UNUSED_PARAMETER css::uno::Reference< css::uno::XComponentContext >
+        const &)
 {
     return static_cast< cppu::OWeakObject * >(new SimpleRegistry);
 }
diff --git a/stoc/source/tdmanager/tdmgr_check.cxx b/stoc/source/tdmanager/tdmgr_check.cxx
index 32d8ca1651a7..99f341cd8e12 100644
--- a/stoc/source/tdmanager/tdmgr_check.cxx
+++ b/stoc/source/tdmanager/tdmgr_check.cxx
@@ -209,11 +209,11 @@ void checkRestParam( Reference<reflection::XParameter> const & xNewParam,
         typeError( OUSTR("Different ... parameters specified!"), context );
 }
 
-void checkRestParam( Reference<reflection::XMethodParameter> const &,
-                     Reference<reflection::XMethodParameter> const &,
-                     OUString const & )
-{
-}
+void checkRestParam(
+    SAL_UNUSED_PARAMETER Reference<reflection::XMethodParameter> const &,
+    SAL_UNUSED_PARAMETER Reference<reflection::XMethodParameter> const &,
+    SAL_UNUSED_PARAMETER OUString const & )
+{}
 
 template<typename T>
 void checkParameters( Sequence< Reference<T> > const & newParams,
diff --git a/stoc/source/typeconv/convert.cxx b/stoc/source/typeconv/convert.cxx
index 859b2cff16bc..d19c8a3a0232 100644
--- a/stoc/source/typeconv/convert.cxx
+++ b/stoc/source/typeconv/convert.cxx
@@ -934,7 +934,7 @@ namespace stoc_services
 {
 //*************************************************************************
 Reference< XInterface > SAL_CALL TypeConverter_Impl_CreateInstance(
-    const Reference< XComponentContext > & )
+    SAL_UNUSED_PARAMETER const Reference< XComponentContext > & )
     throw( RuntimeException )
 {
     static Reference< XInterface > s_ref( (OWeakObject *) new stoc_tcv::TypeConverter_Impl() );
diff --git a/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTexpand.cxx b/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTexpand.cxx
index 3f9601d2e4b6..1b42111140c1 100644
--- a/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTexpand.cxx
+++ b/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTexpand.cxx
@@ -234,7 +234,8 @@ css::uno::Reference< css::uri::XUriReference > Parser::parse(
 namespace stoc_services { namespace UriSchemeParser_vndDOTsunDOTstarDOTexpand {
 
 css::uno::Reference< css::uno::XInterface > create(
-    css::uno::Reference< css::uno::XComponentContext > const &)
+    SAL_UNUSED_PARAMETER css::uno::Reference< css::uno::XComponentContext >
+        const &)
     SAL_THROW((css::uno::Exception))
 {
     //TODO: single instance
diff --git a/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx b/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx
index 882bc7e79947..690458d1869e 100644
--- a/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx
+++ b/stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx
@@ -457,7 +457,8 @@ namespace stoc_services {
 namespace UriSchemeParser_vndDOTsunDOTstarDOTscript {
 
 css::uno::Reference< css::uno::XInterface > create(
-    css::uno::Reference< css::uno::XComponentContext > const &)
+    SAL_UNUSED_PARAMETER css::uno::Reference< css::uno::XComponentContext >
+        const &)
     SAL_THROW((css::uno::Exception))
 {
     //TODO: single instance