diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
| commit | e3133ae2371b6e2d4b47daa6a3487ea4f2753315 (patch) | |
| tree | f9a000ee6542fb470733bfed28199092a36c26c5 /stoc | |
| parent | 14f4e2fa22a0a2576808bab08edaf2e12f761cd8 (diff) | |
Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
Diffstat (limited to 'stoc')
| -rw-r--r-- | stoc/source/security/permissions.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/stoc/source/security/permissions.cxx b/stoc/source/security/permissions.cxx index 72b14b318e59..f2b8e3120152 100644 --- a/stoc/source/security/permissions.cxx +++ b/stoc/source/security/permissions.cxx @@ -236,7 +236,7 @@ bool SocketPermission::implies( Permission const & perm ) const SAL_THROW(()) return false; if (! demanded.resolveHost()) return false; - return (sal_False != m_ip.equals( demanded.m_ip )); + return m_ip.equals( demanded.m_ip ); } //__________________________________________________________________________________________________ OUString SocketPermission::toString() const SAL_THROW(()) @@ -455,7 +455,7 @@ bool RuntimePermission::implies( Permission const & perm ) const SAL_THROW(()) RuntimePermission const & demanded = static_cast< RuntimePermission const & >( perm ); // check name - return (sal_False != m_name.equals( demanded.m_name )); + return m_name.equals( demanded.m_name ); } //__________________________________________________________________________________________________ OUString RuntimePermission::toString() const SAL_THROW(()) |