diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /stoc | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'stoc')
| -rw-r--r-- | stoc/source/inspect/introspection.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/stoc/source/inspect/introspection.cxx b/stoc/source/inspect/introspection.cxx index 09dc11ba9e54..6361044d42b8 100644 --- a/stoc/source/inspect/introspection.cxx +++ b/stoc/source/inspect/introspection.cxx @@ -137,7 +137,7 @@ sal_Bool isDerivedFrom( Reference<XIdlClass> xToTestClass, Reference<XIdlClass> // Hashtable for the search of names struct hashName_Impl { - size_t operator()(const OUString Str) const + size_t operator()(const OUString& Str) const { return (size_t)Str.hashCode(); } @@ -145,7 +145,7 @@ struct hashName_Impl struct eqName_Impl { - sal_Bool operator()(const OUString Str1, const OUString Str2) const + sal_Bool operator()(const OUString& Str1, const OUString& Str2) const { return ( Str1 == Str2 ); } @@ -1411,7 +1411,7 @@ Any ImplIntrospectionAccess::getMaterial(void) throw(RuntimeException, std::exce } // Hilfs-Funktion zur LowerCase-Wandlung eines OUString -OUString toLower( OUString aUStr ) +OUString toLower( const OUString& aUStr ) { // Tabelle fuer XExactName pflegen OUString aOWStr( aUStr.getStr() ); |