Use -W4 instead of -Wall, and don't disable warnings that are off by default

2 files changed, 4 insertions, 92 deletions

diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk
index b45d47a085ae..a81b5df9d8f3 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -76,18 +76,12 @@ gb_AFLAGS := /c /Cp
 
 # C4005: 'identifier' : macro redefinition
 
-# C4061: enumerator 'identifier' in switch of enum 'enumeration' is
-#   not explicitly handled by a case label
-
 # C4127: conditional expression is constant
 
 # C4180: qualifier applied to function type has no meaning; ignored
 
 # C4189: 'identifier' : local variable is initialized but not referenced
 
-# C4191: 'operator/operation' : unsafe conversion from 'type of
-#   expression' to 'type required'
-
 # C4242: 'identifier' : conversion from 'type1' to 'type2', possible
 #   loss of data
 
@@ -114,16 +108,11 @@ gb_AFLAGS := /c /Cp
 # C4290: C++ exception specification ignored except to indicate a
 #   function is not __declspec(nothrow)
 
-# C4350: behavior change: 'member1' called instead of 'member2'
-
 # C4351: new behavior: elements of array 'array' will be default
 #   initialized
 
 # C4355: 'this' : used in base member initializer list
 
-# C4365: 'action' : conversion from 'type_1' to 'type_2',
-#   signed/unsigned mismatch
-
 # C4373: '%$S': virtual function overrides '%$pS', previous versions
 #   of the compiler did not override when parameters only differed by
 #   const/volatile qualifiers.
@@ -137,56 +126,19 @@ gb_AFLAGS := /c /Cp
 
 # C4512: 'class' : assignment operator could not be generated
 
-# C4514: 'function' : unreferenced inline function has been removed
-
-# C4555: expression has no effect; expected expression with
-#   side-effect
-
 # C4611: interaction between 'function' and C++ object destruction is
 #   non-portable
 
-# C4619: #pragma warning : there is no warning number 'number'
-
-# C4625: 'derived class' : copy constructor could not be generated
-#   because a base class copy constructor is inaccessible
-
 # C4626: 'derived class' : assignment operator could not be generated
 #   because a base class assignment operator is inaccessible
 
-# C4628: digraphs not supported with -Ze. Character sequence 'digraph'
-#   not interpreted as alternate token for 'char'
-
 # C4640: 'instance' : construction of local static object is not thread-safe
 
-# C4668: 'symbol' is not defined as a preprocessor macro, replacing
-#   with '0' for 'directives'
-
-# C4686: ' user-defined type ' : possible change in behavior, change
-#   in UDT return calling convention
-
-# C4692: 'function': signature of non-private member contains assembly
-#   private native type 'native_type'
-
 # C4706: assignment within conditional expression
 
-# C4710: 'function' : function not inlined
-
-# C4711: function 'function' selected for inline expansion
-
-# C4738: storing 32-bit float result in memory, possible loss of
-#   performance
-
 # C4800: 'type' : forcing value to bool 'true' or 'false' (performance
 #   warning)
 
-# C4820: 'bytes' bytes padding added after construct 'member_name'
-
-# C4826: Conversion from 'type1 ' to 'type_2' is sign-extended. This
-#   may cause unexpected runtime behavior.
-
-# C4917: 'declarator' : a GUID can only be associated with a class,
-#   interface or namespace
-
 # C4996: 'function': was declared deprecated
 
 gb_CFLAGS := \
@@ -196,13 +148,11 @@ gb_CFLAGS := \
 	-GS \
 	-MD \
 	-nologo \
-	-Wall \
+	-W4 \
 	-wd4005 \
-	-wd4061 \
 	-wd4127 \
 	-wd4180 \
 	-wd4189 \
-	-wd4191 \
 	-wd4242 \
 	-wd4244 \
 	-wd4245 \
@@ -211,31 +161,16 @@ gb_CFLAGS := \
 	-wd4255 \
 	-wd4275 \
 	-wd4290 \
-	-wd4350 \
 	-wd4355 \
-	-wd4365 \
 	-wd4503 \
 	-wd4505 \
 	-wd4511 \
 	-wd4512 \
-	-wd4514 \
-	-wd4555 \
 	-wd4611 \
-	-wd4619 \
-	-wd4625 \
 	-wd4626 \
 	-wd4640 \
-	-wd4668 \
-	-wd4686 \
-	-wd4692 \
 	-wd4706 \
-	-wd4710 \
-	-wd4711 \
-	-wd4738 \
 	-wd4800 \
-	-wd4820 \
-	-wd4826 \
-	-wd4917 \
 	-Zc:forScope,wchar_t- \
 	-Zm500 \
 
@@ -247,13 +182,11 @@ gb_CXXFLAGS := \
 	-Gy \
 	-MD \
 	-nologo \
-	-Wall \
+	-W4 \
 	-wd4005 \
-	-wd4061 \
 	-wd4127 \
 	-wd4180 \
 	-wd4189 \
-	-wd4191 \
 	-wd4242 \
 	-wd4244 \
 	-wd4245 \
@@ -262,34 +195,18 @@ gb_CXXFLAGS := \
 	-wd4265 \
 	-wd4275 \
 	-wd4290 \
-	-wd4350 \
 	-wd4351 \
 	-wd4355 \
-	-wd4365 \
 	-wd4373 \
 	-wd4503 \
 	-wd4505 \
 	-wd4511 \
 	-wd4512 \
-	-wd4514 \
-	-wd4555 \
 	-wd4611 \
-	-wd4619 \
-	-wd4625 \
 	-wd4626 \
-	-wd4628 \
 	-wd4640 \
-	-wd4668 \
-	-wd4686 \
-	-wd4692 \
 	-wd4706 \
-	-wd4710 \
-	-wd4711 \
-	-wd4738 \
 	-wd4800 \
-	-wd4820 \
-	-wd4826 \
-	-wd4917 \
 	-wd4996 \
 	-Zc:forScope,wchar_t- \
 	-Zm500 \
@@ -299,12 +216,7 @@ gb_CXXFLAGS := \
 # need them disabled.
 ifeq ($(VCVER),100)
 
-# C4986: 'function': exception specification does not match previous
-#   declaration. This warning is generated by VS2012 headers (!), and is
-#   C++-only.
-
-gb_CXXFLAGS += \
-	-wd4986 \
+# (none currently)
 
 endif
 
diff --git a/solenv/inc/wntmsc.mk b/solenv/inc/wntmsc.mk
index 9f2941d3dd5f..654d63b165a5 100644
--- a/solenv/inc/wntmsc.mk
+++ b/solenv/inc/wntmsc.mk
@@ -183,7 +183,7 @@ CFLAGSOUTOBJ=-Fo
 #   '()' to '(void)'".
 # - "warning C4365: conversion from ... to ... signed/unsigned mismatch"
 
-CFLAGSWARNCXX=-Wall -wd4061 -wd4127 -wd4191 -wd4217 -wd4242 -wd4244 -wd4245 -wd4250 -wd4251 -wd4275 \
+CFLAGSWARNCXX=-W4 -wd4061 -wd4127 -wd4191 -wd4217 -wd4242 -wd4244 -wd4245 -wd4250 -wd4251 -wd4275 \
     -wd4290 -wd4294 -wd4355 -wd4511 -wd4512 -wd4514 -wd4555 -wd4611 -wd4625 -wd4626 \
     -wd4640 -wd4675 -wd4686 -wd4706 -wd4710 -wd4711 -wd4786 -wd4800 -wd4820 -wd4503 -wd4619 \
     -wd4365 -wd4668 -wd4738 -wd4826 -wd4350 -wd4505 -wd4692 -wd4189 -wd4005 \